You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@phoenix.apache.org by "Andrew Purtell (JIRA)" <ji...@apache.org> on 2019/05/09 18:16:00 UTC

[jira] [Comment Edited] (PHOENIX-5119) Work around RpcScheduler interface differences in HBase 1.5

    [ https://issues.apache.org/jira/browse/PHOENIX-5119?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16836601#comment-16836601 ] 

Andrew Purtell edited comment on PHOENIX-5119 at 5/9/19 6:15 PM:
-----------------------------------------------------------------

[~lhofhansl] Yes now there is the other issue with ObserverContext, I think a branch is warranted now and we don't need to take the approach on this JIRA. In my private fork of 4.14.2-SNAPSHOT I am using with 1.5.0-SNAPSHOT I just make the necessary interface changes without the reflection (and also handle the changes for ObserverContext). Shall we open a new JIRA to commit that patch out in open source?


was (Author: apurtell):
[~lhofhansl] Yes now there is the other issue with ObserverContext, I think a branch is warranted now and we don't need to take the approach on this JIRA. In my private fork of 1.5.0 I am using with 4.14.2-SNAPSHOT I just make the necessary interface changes without the reflection (and also handle the changes for ObserverContext). Shall we open a new JIRA to commit that patch out in open source?

> Work around RpcScheduler interface differences in HBase 1.5
> -----------------------------------------------------------
>
>                 Key: PHOENIX-5119
>                 URL: https://issues.apache.org/jira/browse/PHOENIX-5119
>             Project: Phoenix
>          Issue Type: Bug
>            Reporter: Andrew Purtell
>            Assignee: Andrew Purtell
>            Priority: Major
>         Attachments: PHOENIX-5119-4.x.patch
>
>
> The RpcScheduler interface in HBase 1.5 has three new methods for exposing per handler type counts for RPC metrics. Implement them using reflection and avoid use of any @Override annotations so the code will continue to compile against earlier versions.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)