[impala] 01/02: IMPALA-8950: Set overwrite to False by default in fs_client.copy

[cs...@apache.org]

This is an automated email from the ASF dual-hosted git repository.

csringhofer pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/impala.git

commit b0b8f20267f96c902eee5bab85475ee41645bbe3
Author: Sahil Takiar <ta...@gmail.com>
AuthorDate: Thu Oct 10 09:13:21 2019 -0700

    IMPALA-8950: Set overwrite to False by default in fs_client.copy
    
    test_udfs.py and test_load.py are consistently failing on S3 with
    the following error:
    
    E   TypeError: copy() takes exactly 4 arguments (3 given)
    
    The issue is that a new parameter 'overwrite' was added to the method
    'HadoopFsCommandLineClient.copy', but with no default value. This patch
    fixes the issue by adding 'overwrite=False'.
    
    Testing:
    * Ran core tests on S3
    
    Change-Id: I1935e0c92f7402e727ee16596485147cf1a5a516
    Reviewed-on: http://gerrit.cloudera.org:8080/14432
    Reviewed-by: Impala Public Jenkins <im...@cloudera.com>
    Tested-by: Impala Public Jenkins <im...@cloudera.com>
---
 tests/util/hdfs_util.py | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/tests/util/hdfs_util.py b/tests/util/hdfs_util.py
index b22dec4..81d07e6 100644
--- a/tests/util/hdfs_util.py
+++ b/tests/util/hdfs_util.py
@@ -226,7 +226,7 @@ class HadoopFsCommandLineClient(BaseFilesystem):
     (status, stdout, stderr) = self._hadoop_fs_shell(['-mkdir', '-p', fixed_path])
     return status == 0
 
-  def copy(self, src, dst, overwrite):
+  def copy(self, src, dst, overwrite=False):
     """Copy the source file to the destination. Specifes the '-d' option by default, which
     'Skip[s] creation of temporary file with the suffix ._COPYING_.' to avoid extraneous
     copies on S3. If overwrite is true, the destination file is overwritten, set to false