You are viewing a plain text version of this content. The canonical link for it is here.

Posted to commits@dolphinscheduler.apache.org by GitBox <gi...@apache.org> on 2021/02/06 02:21:13 UTC

[GitHub] [incubator-dolphinscheduler] lenboo commented on a change in pull request #4678: [FIX-#3805][server-master] global params of master

lenboo commented on a change in pull request #4678:
URL: https://github.com/apache/incubator-dolphinscheduler/pull/4678#discussion_r571341431



##########
File path: dolphinscheduler-dao/src/main/java/org/apache/dolphinscheduler/dao/mapper/ProcessInstanceMapper.java
##########
@@ -221,4 +221,5 @@ ProcessInstance queryLastManualProcess(@Param("processDefinitionId") int definit
             @Param("processDefinitionId") int processDefinitionId,
             @Param("states") int[] states);
 
+    int updateGlobalParamById(@Param("globalParams") String globalParams,@Param("id")  int id);

Review comment:
        one line for each parameter is the general way of writing




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org