You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@flume.apache.org by Hari Shreedharan <hs...@cloudera.com> on 2012/03/27 08:31:31 UTC
Review Request: Memory channel configuration
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/4512/
-----------------------------------------------------------
Review request for Flume.
Summary
-------
Memory channel configuration
This addresses bug FLUME-1062.
https://issues.apache.org/jira/browse/FLUME-1062
Diffs
-----
flume-ng-configuration/src/main/java/org/apache/flume/conf/channel/MemoryChannelConfiguration.java PRE-CREATION
flume-ng-core/src/main/java/org/apache/flume/channel/MemoryChannel.java bfa1fde
Diff: https://reviews.apache.org/r/4512/diff
Testing
-------
Thanks,
Hari
Re: Review Request: Memory channel configuration
Posted by Juhani Connolly <ju...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/4512/#review6509
-----------------------------------------------------------
Looks good. Just one nitpick
flume-ng-configuration/src/main/java/org/apache/flume/conf/channel/MemoryChannelConfiguration.java
<https://reviews.apache.org/r/4512/#comment14164>
It would be nice if you could add a warning of some sort since the configuration is "incorrect"
- Juhani
On 2012-03-27 06:31:31, Hari Shreedharan wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/4512/
> -----------------------------------------------------------
>
> (Updated 2012-03-27 06:31:31)
>
>
> Review request for Flume.
>
>
> Summary
> -------
>
> Memory channel configuration
>
>
> This addresses bug FLUME-1062.
> https://issues.apache.org/jira/browse/FLUME-1062
>
>
> Diffs
> -----
>
> flume-ng-configuration/src/main/java/org/apache/flume/conf/channel/MemoryChannelConfiguration.java PRE-CREATION
> flume-ng-core/src/main/java/org/apache/flume/channel/MemoryChannel.java bfa1fde
>
> Diff: https://reviews.apache.org/r/4512/diff
>
>
> Testing
> -------
>
>
> Thanks,
>
> Hari
>
>