[GitHub] graceguo-supercat closed pull request #5624: [Dashobard] Fix bad merge

[GitBox <gi...@apache.org>]

graceguo-supercat closed pull request #5624: [Dashobard] Fix bad merge
URL: https://github.com/apache/incubator-superset/pull/5624
 
 
   

This is a PR merged from a forked repository.
As GitHub hides the original diff on merge, it is displayed below for
the sake of provenance:

As this is a foreign pull request (from a fork), the diff is supplied
below (as it won't show otherwise due to GitHub magic):

diff --git a/superset/views/core.py b/superset/views/core.py
index 71f6ff1f21..2371abaf32 100755
--- a/superset/views/core.py
+++ b/superset/views/core.py
@@ -1614,7 +1614,6 @@ def _set_dash_metadata(dashboard, data):
         # remove leading and trailing white spaces in the dumped json
         dashboard.position_json = json.dumps(
             positions, indent=None, separators=(',', ':'), sort_keys=True)
-        dashboard.position_json = json.dumps(positions, sort_keys=True)
         md = dashboard.params_dict
         dashboard.css = data.get('css')
         dashboard.dashboard_title = data['dashboard_title']


 

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org