You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@tvm.apache.org by GitBox <gi...@apache.org> on 2022/06/03 15:51:52 UTC
[GitHub] [tvm] billishyahao opened a new pull request, #11560: [DNNL] Fix end of line in test_dnnl UT file
billishyahao opened a new pull request, #11560:
URL: https://github.com/apache/tvm/pull/11560
The end of line in test_dnnl.py is CRLF which is not identical to other python files. This patch is going to fix this by replacing CRLF to LF.
Thanks for contributing to TVM! Please refer to guideline https://tvm.apache.org/docs/contribute/ for useful information and tips. After the pull request is submitted, please request code reviews from [Reviewers](https://github.com/apache/incubator-tvm/blob/master/CONTRIBUTORS.md#reviewers) by @ them in the pull request thread.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@tvm.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [tvm] masahi merged pull request #11560: [DNNL] Fix end of line in test_dnnl UT file
Posted by GitBox <gi...@apache.org>.
masahi merged PR #11560:
URL: https://github.com/apache/tvm/pull/11560
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@tvm.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [tvm] AndrewZhaoLuo commented on pull request #11560: [DNNL] Fix end of line in test_dnnl UT file
Posted by GitBox <gi...@apache.org>.
AndrewZhaoLuo commented on PR #11560:
URL: https://github.com/apache/tvm/pull/11560#issuecomment-1147617770
If I understand this change correctly this is entirely style; git will handle different line deliminators fine, but the issue is that if a windows dev edits a file with LF, it will replace all lines with CRLF through the entire file which means every line will be changed in diffs. This will make the commit log a bit gummier.
cc @areusch @driazati it seems like a good idea to force LF for new lines? can we lint for this.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@tvm.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [tvm] masahi commented on pull request #11560: [DNNL] Fix end of line in test_dnnl UT file
Posted by GitBox <gi...@apache.org>.
masahi commented on PR #11560:
URL: https://github.com/apache/tvm/pull/11560#issuecomment-1146317234
Why do we need to fix this?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@tvm.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [tvm] billishyahao commented on pull request #11560: [DNNL] Fix end of line in test_dnnl UT file
Posted by GitBox <gi...@apache.org>.
billishyahao commented on PR #11560:
URL: https://github.com/apache/tvm/pull/11560#issuecomment-1149401090
Hi @masahi , @AndrewZhaoLuo , I hit this issue when I am trying to accomplish my another PR https://github.com/apache/tvm/pull/11513 . It seems that somebody use windows as development environment and unexpectedly reformat the whole LF to CRLF. Git status command shows this change and it is annoying for other developer of tvm. To eliminate this issue, I propose this patch.
As Andrew 's words, it is better to enable lint to avoid other people to change LF to CRLF unexpectedly.
@AndrewZhaoLuo Hi, may I continue merging this change?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@tvm.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [tvm] driazati commented on pull request #11560: [DNNL] Fix end of line in test_dnnl UT file
Posted by GitBox <gi...@apache.org>.
driazati commented on PR #11560:
URL: https://github.com/apache/tvm/pull/11560#issuecomment-1148981808
We should definitely check for this kind of thing in CI, opened #11609
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@tvm.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [tvm] billishyahao commented on pull request #11560: [DNNL] Fix end of line in test_dnnl UT file
Posted by GitBox <gi...@apache.org>.
billishyahao commented on PR #11560:
URL: https://github.com/apache/tvm/pull/11560#issuecomment-1146098563
Hi @masahi , Could you please review this change?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@tvm.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org