You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@stanbol.apache.org by rw...@apache.org on 2011/02/09 11:55:52 UTC
svn commit: r1068838 - /incubator/stanbol/trunk/enhancer/pom.xml
Author: rwesten
Date: Wed Feb 9 10:55:52 2011
New Revision: 1068838
URL: http://svn.apache.org/viewvc?rev=1068838&view=rev
Log:
In revision 1064727 the integration-test module was enabled for stanbol enhancer (see STANBOL-19 for details). However the dependency of the integration-test module to the launchers/full module caused the build order to be changed. Specifically the launchers/full module was build before the clerezza/clerezza-sparql module.
Because of that the build process was broken if the bundle created by the clerezza/clerezza-sparql module was not already present in the local maven represitory (e.g. from a previous build).
This change moves the integration-module after the launchers (and the clerezza/clerezza-sparql module) and therefore restores the intended build order.
Modified:
incubator/stanbol/trunk/enhancer/pom.xml
Modified: incubator/stanbol/trunk/enhancer/pom.xml
URL: http://svn.apache.org/viewvc/incubator/stanbol/trunk/enhancer/pom.xml?rev=1068838&r1=1068837&r2=1068838&view=diff
==============================================================================
--- incubator/stanbol/trunk/enhancer/pom.xml (original)
+++ incubator/stanbol/trunk/enhancer/pom.xml Wed Feb 9 10:55:52 2011
@@ -61,7 +61,6 @@
<module>engines/zemanta</module>
<module>jersey</module>
- <module>integration-tests</module>
<module>clerezza/org.apache.stanbol.enhancer.clerezza</module>
<module>clerezza/clerezza-sparql</module>
@@ -69,6 +68,8 @@
<module>launchers/full</module>
<module>launchers/lite</module>
+ <module>integration-tests</module>
+
<module>SemiAutomaticContentEnhancer</module>
</modules>
</project>
Re: svn commit: r1068838 - /incubator/stanbol/trunk/enhancer/pom.xml
Posted by Rupert Westenthaler <rw...@apache.org>.
>> This change moves the integration-module after the launchers (and the clerezza/clerezza-sparql module)
>> and therefore restores the intended build order.
>
> In theory, AFAIK, Maven should handle that correctly...do we have any
> cyclic dependencies or something that messes up Maven's dependency
> resolution?
>
Thats true, but the dependency of the launchers/full module to the
clerezza/clerezza-sparql is not visible to Maven, because it is only
given by the fact that the "list.xml" used to configure the Sling
launcher refers this bundle.
I think one would need to add all the dependencies to stanbol bundles
to the pom files of the launchers to allow Maven to put them in the
right order.
best RUpert
--
| Rupert Westenthaler rwesten@apache.org
| Bodenlehenstraße 11 ++43-699-11108907
| A-5500 Bischofshofen
Re: svn commit: r1068838 - /incubator/stanbol/trunk/enhancer/pom.xml
Posted by Bertrand Delacretaz <bd...@apache.org>.
On Wed, Feb 9, 2011 at 11:55 AM, <rw...@apache.org> wrote:
>...
> URL: http://svn.apache.org/viewvc?rev=1068838&view=rev
>...
> This change moves the integration-module after the launchers (and the clerezza/clerezza-sparql module)
> and therefore restores the intended build order.
In theory, AFAIK, Maven should handle that correctly...do we have any
cyclic dependencies or something that messes up Maven's dependency
resolution?
-Bertrand
Re: svn commit: r1068838 - /incubator/stanbol/trunk/enhancer/pom.xml
Posted by Olivier Grisel <og...@apache.org>.
2011/2/9 <rw...@apache.org>:
> Author: rwesten
> Date: Wed Feb 9 10:55:52 2011
> New Revision: 1068838
>
> URL: http://svn.apache.org/viewvc?rev=1068838&view=rev
> Log:
> In revision 1064727 the integration-test module was enabled for stanbol enhancer (see STANBOL-19 for details). However the dependency of the integration-test module to the launchers/full module caused the build order to be changed. Specifically the launchers/full module was build before the clerezza/clerezza-sparql module.
> Because of that the build process was broken if the bundle created by the clerezza/clerezza-sparql module was not already present in the local maven represitory (e.g. from a previous build).
> This change moves the integration-module after the launchers (and the clerezza/clerezza-sparql module) and therefore restores the intended build order.
Thank you very much for fixing this! I was trying to understand what
was going on myself.
--
Olivier