You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@commons.apache.org by "Ioannis Canellos (JIRA)" <ji...@apache.org> on 2010/09/02 17:30:53 UTC

[jira] Created: (DBCP-341) LocalXAConnectionFactory does not properly checks if Xid is equal to currentXid when resuming

LocalXAConnectionFactory does not properly checks if Xid is equal to currentXid when resuming
---------------------------------------------------------------------------------------------

                 Key: DBCP-341
                 URL: https://issues.apache.org/jira/browse/DBCP-341
             Project: Commons Dbcp
          Issue Type: Bug
    Affects Versions: 1.4
            Reporter: Ioannis Canellos


The current implementation checks if Xid is not equal to currentXid using the != . That doesn't work in all cases resulting in XAException.
I think that this check should be left to the Xid implementation.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

[jira] Updated: (DBCP-341) LocalXAConnectionFactory does not properly checks if Xid is equal to currentXid when resuming

Posted by "Ioannis Canellos (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/DBCP-341?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Ioannis Canellos updated DBCP-341:
----------------------------------

    Attachment: DBPC-341-patch.txt

I am attaching a patch that replaces the != operation with a call the Xid equals method.

> LocalXAConnectionFactory does not properly checks if Xid is equal to currentXid when resuming
> ---------------------------------------------------------------------------------------------
>
>                 Key: DBCP-341
>                 URL: https://issues.apache.org/jira/browse/DBCP-341
>             Project: Commons Dbcp
>          Issue Type: Bug
>    Affects Versions: 1.4
>            Reporter: Ioannis Canellos
>         Attachments: DBPC-341-patch.txt
>
>
> The current implementation checks if Xid is not equal to currentXid using the != . That doesn't work in all cases resulting in XAException.
> I think that this check should be left to the Xid implementation.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.