[GitHub] [accumulo] ddanielr commented on a diff in pull request #3172: fix parameter timeout checks, rename timeOut to retryTimeout

["ddanielr (via GitHub)" <gi...@apache.org>]

ddanielr commented on code in PR #3172:
URL: https://github.com/apache/accumulo/pull/3172#discussion_r1086106035


##########
core/src/main/java/org/apache/accumulo/core/client/ClientSideIteratorScanner.java:
##########
@@ -213,7 +213,7 @@ public ClientSideIteratorScanner(final Scanner scanner) {
     smi = new ScannerTranslatorImpl(scanner, scanner.getSamplerConfiguration());
     this.range = scanner.getRange();
     this.size = scanner.getBatchSize();
-    this.timeOut = scanner.getTimeout(MILLISECONDS);
+    this.retryTimeout = scanner.getTimeout(MILLISECONDS);
     this.batchTimeOut = scanner.getTimeout(MILLISECONDS);

Review Comment:
   Does it make sense to also update `batchTimeOut` to match the case of `retryTimeout` for uniformity?
   



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@accumulo.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org