[GitHub] [iceberg] openinx commented on a change in pull request #2303: Core: Remove all delete files in RewriteFiles action.

[GitBox <gi...@apache.org>]

openinx commented on a change in pull request #2303:
URL: https://github.com/apache/iceberg/pull/2303#discussion_r594102116



##########
File path: core/src/main/java/org/apache/iceberg/actions/BaseRewriteDataFilesAction.java
##########
@@ -192,7 +194,7 @@ protected boolean caseSensitive() {
 
   @Override
   public RewriteDataFilesActionResult execute() {
-    CloseableIterable<FileScanTask> fileScanTasks = null;
+    CloseableIterable<FileScanTask> fileScanTasks = CloseableIterable.empty();

Review comment:
       I'm not sure whether this name `RewriteDataFilesActionResult` should be renamed to `RewriteFilesActionResult` because the rewrite action is removing all the deletions from files set, it also rewrite the delete files actually.




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org