You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@ignite.apache.org by GitBox <gi...@apache.org> on 2021/04/21 12:12:35 UTC
[GitHub] [ignite] anton-vinogradov opened a new pull request #9027: IGNITE-14601 Specs should use service's params instead of copying.
anton-vinogradov opened a new pull request #9027:
URL: https://github.com/apache/ignite/pull/9027
Thank you for submitting the pull request to the Apache Ignite.
In order to streamline the review of the contribution
we ask you to ensure the following steps have been taken:
### The Contribution Checklist
- [ ] There is a single JIRA ticket related to the pull request.
- [ ] The web-link to the pull request is attached to the JIRA ticket.
- [ ] The JIRA ticket has the _Patch Available_ state.
- [ ] The pull request body describes changes that have been made.
The description explains _WHAT_ and _WHY_ was made instead of _HOW_.
- [ ] The pull request title is treated as the final commit message.
The following pattern must be used: `IGNITE-XXXX Change summary` where `XXXX` - number of JIRA issue.
- [ ] A reviewer has been mentioned through the JIRA comments
(see [the Maintainers list](https://cwiki.apache.org/confluence/display/IGNITE/How+to+Contribute#HowtoContribute-ReviewProcessandMaintainers))
- [ ] The pull request has been checked by the Teamcity Bot and
the `green visa` attached to the JIRA ticket (see [TC.Bot: Check PR](https://mtcga.gridgain.com/prs.html))
### Notes
- [How to Contribute](https://cwiki.apache.org/confluence/display/IGNITE/How+to+Contribute)
- [Coding abbreviation rules](https://cwiki.apache.org/confluence/display/IGNITE/Abbreviation+Rules)
- [Coding Guidelines](https://cwiki.apache.org/confluence/display/IGNITE/Coding+Guidelines)
- [Apache Ignite Teamcity Bot](https://cwiki.apache.org/confluence/display/IGNITE/Apache+Ignite+Teamcity+Bot)
If you need any help, please email dev@ignite.apache.org or ask anу advice on http://asf.slack.com _#ignite_ channel.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [ignite] anton-vinogradov merged pull request #9027: IGNITE-14601 Specs should use service's params instead of copying.
Posted by GitBox <gi...@apache.org>.
anton-vinogradov merged pull request #9027:
URL: https://github.com/apache/ignite/pull/9027
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [ignite] anton-vinogradov commented on a change in pull request #9027: IGNITE-14601 Specs should use service's params instead of copying.
Posted by GitBox <gi...@apache.org>.
anton-vinogradov commented on a change in pull request #9027:
URL: https://github.com/apache/ignite/pull/9027#discussion_r617517468
##########
File path: modules/ducktests/tests/ignitetest/services/utils/ignite_aware.py
##########
@@ -19,13 +19,13 @@
import os
import re
import signal
-import sys
-import time
from abc import ABCMeta
from datetime import datetime
from enum import IntEnum
from threading import Thread
+import sys
+import time
Review comment:
Have no clue why, but IDEA thinks that this should be replaced.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [ignite] anton-vinogradov commented on a change in pull request #9027: IGNITE-14601 Specs should use service's params instead of copying.
Posted by GitBox <gi...@apache.org>.
anton-vinogradov commented on a change in pull request #9027:
URL: https://github.com/apache/ignite/pull/9027#discussion_r617517468
##########
File path: modules/ducktests/tests/ignitetest/services/utils/ignite_aware.py
##########
@@ -19,13 +19,13 @@
import os
import re
import signal
-import sys
-import time
from abc import ABCMeta
from datetime import datetime
from enum import IntEnum
from threading import Thread
+import sys
+import time
Review comment:
Have no clue why, but IDEA thinks that this should be replaced.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org