[GitHub] [pulsar] lhotari commented on pull request #15051: [fix][broker] Fix potential to add duplicated consumer

[GitBox <gi...@apache.org>]

lhotari commented on PR #15051:
URL: https://github.com/apache/pulsar/pull/15051#issuecomment-1092431543

   > > Seems that this PR only enhances the exception handling. Could you provide more information on how this PR fixed the duplicated consumer issue?
   > 
   > The key point for the problem was "possibly delete a running CompletableFuture", the logic of the original code was not rigorous enough. this PR solved it.
   
   I was wondering about the same thing whether this is just a refactoring. This does fix a race condition in providing the error message. It's possible the the CompletableFuture completes after it has been checked. In that case, the old code might have provided a wrong error message.
   
   @poorbarcode  I don't think that this PR prevents duplicated consumers. Could you explain how it achieves that?
   
   
   
   
   
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org