You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@mesos.apache.org by Anand Mazumdar <ma...@gmail.com> on 2015/08/11 02:17:53 UTC
Review Request 37328: Remove namespace ambiguity
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/37328/
-----------------------------------------------------------
Review request for mesos, Ben Mahler and Vinod Kone.
Repository: mesos
Description
-------
Remove namespace ambiguity. Needed for r37303
Diffs
-----
src/tests/common/http_tests.cpp 38d062b2b4062e0a2fc912bad0cc2d73339eb66e
Diff: https://reviews.apache.org/r/37328/diff/
Testing
-------
make check
Thanks,
Anand Mazumdar
Re: Review Request 37328: Remove namespace ambiguity
Posted by Mesos ReviewBot <re...@mesos.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/37328/#review94849
-----------------------------------------------------------
Patch looks great!
Reviews applied: [37300, 37328]
All tests passed.
- Mesos ReviewBot
On Aug. 11, 2015, 12:17 a.m., Anand Mazumdar wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/37328/
> -----------------------------------------------------------
>
> (Updated Aug. 11, 2015, 12:17 a.m.)
>
>
> Review request for mesos, Ben Mahler and Vinod Kone.
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Remove namespace ambiguity. Needed for r37303
>
>
> Diffs
> -----
>
> src/tests/common/http_tests.cpp 38d062b2b4062e0a2fc912bad0cc2d73339eb66e
>
> Diff: https://reviews.apache.org/r/37328/diff/
>
>
> Testing
> -------
>
> make check
>
>
> Thanks,
>
> Anand Mazumdar
>
>
Re: Review Request 37328: Remove namespace ambiguity
Posted by Mesos ReviewBot <re...@mesos.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/37328/#review95241
-----------------------------------------------------------
Patch looks great!
Reviews applied: [37302, 37303, 37328]
All tests passed.
- Mesos ReviewBot
On Aug. 13, 2015, 5:43 a.m., Anand Mazumdar wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/37328/
> -----------------------------------------------------------
>
> (Updated Aug. 13, 2015, 5:43 a.m.)
>
>
> Review request for mesos, Ben Mahler and Vinod Kone.
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Remove namespace ambiguity. Needed for r37303
>
>
> Diffs
> -----
>
> src/tests/common/http_tests.cpp 38d062b2b4062e0a2fc912bad0cc2d73339eb66e
>
> Diff: https://reviews.apache.org/r/37328/diff/
>
>
> Testing
> -------
>
> make check
>
>
> Thanks,
>
> Anand Mazumdar
>
>
Re: Review Request 37328: Remove namespace ambiguity
Posted by Anand Mazumdar <ma...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/37328/
-----------------------------------------------------------
(Updated Aug. 13, 2015, 5:43 a.m.)
Review request for mesos, Ben Mahler and Vinod Kone.
Changes
-------
Make review bot run
Repository: mesos
Description
-------
Remove namespace ambiguity. Needed for r37303
Diffs (updated)
-----
src/tests/common/http_tests.cpp 38d062b2b4062e0a2fc912bad0cc2d73339eb66e
Diff: https://reviews.apache.org/r/37328/diff/
Testing
-------
make check
Thanks,
Anand Mazumdar
Re: Review Request 37328: Remove namespace ambiguity
Posted by Anand Mazumdar <ma...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/37328/
-----------------------------------------------------------
(Updated Aug. 11, 2015, 7:47 p.m.)
Review request for mesos, Ben Mahler and Vinod Kone.
Changes
-------
updated "depends on" -- @vinodkone
Repository: mesos
Description
-------
Remove namespace ambiguity. Needed for r37303
Diffs
-----
src/tests/common/http_tests.cpp 38d062b2b4062e0a2fc912bad0cc2d73339eb66e
Diff: https://reviews.apache.org/r/37328/diff/
Testing
-------
make check
Thanks,
Anand Mazumdar
Re: Review Request 37328: Remove namespace ambiguity
Posted by Anand Mazumdar <ma...@gmail.com>.
> On Aug. 11, 2015, 7:04 p.m., Vinod Kone wrote:
> > src/tests/common/http_tests.cpp, lines 40-42
> > <https://reviews.apache.org/r/37328/diff/1/?file=1036934#file1036934line40>
> >
> > reorder alphabetically.
Why ? We have alphabetical norms for using declarations "within" the same scope i.e. ( using std::string followed by using std::vector etc in order ).
But we tend to go from stdc++ -> libprocess -> stout -> mesos_internal for using directives i.e. in order of header includes or am I missing something here ?
I am dropping the issue for now. Feel free to re-open though
- Anand
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/37328/#review94970
-----------------------------------------------------------
On Aug. 11, 2015, 7:47 p.m., Anand Mazumdar wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/37328/
> -----------------------------------------------------------
>
> (Updated Aug. 11, 2015, 7:47 p.m.)
>
>
> Review request for mesos, Ben Mahler and Vinod Kone.
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Remove namespace ambiguity. Needed for r37303
>
>
> Diffs
> -----
>
> src/tests/common/http_tests.cpp 38d062b2b4062e0a2fc912bad0cc2d73339eb66e
>
> Diff: https://reviews.apache.org/r/37328/diff/
>
>
> Testing
> -------
>
> make check
>
>
> Thanks,
>
> Anand Mazumdar
>
>
Re: Review Request 37328: Remove namespace ambiguity
Posted by Vinod Kone <vi...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/37328/#review94970
-----------------------------------------------------------
Ship it!
src/tests/common/http_tests.cpp (lines 38 - 40)
<https://reviews.apache.org/r/37328/#comment149710>
reorder alphabetically.
- Vinod Kone
On Aug. 11, 2015, 3:24 a.m., Anand Mazumdar wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/37328/
> -----------------------------------------------------------
>
> (Updated Aug. 11, 2015, 3:24 a.m.)
>
>
> Review request for mesos, Ben Mahler and Vinod Kone.
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Remove namespace ambiguity. Needed for r37303
>
>
> Diffs
> -----
>
> src/tests/common/http_tests.cpp 38d062b2b4062e0a2fc912bad0cc2d73339eb66e
>
> Diff: https://reviews.apache.org/r/37328/diff/
>
>
> Testing
> -------
>
> make check
>
>
> Thanks,
>
> Anand Mazumdar
>
>
Re: Review Request 37328: Remove namespace ambiguity
Posted by Anand Mazumdar <ma...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/37328/
-----------------------------------------------------------
(Updated Aug. 11, 2015, 3:24 a.m.)
Review request for mesos, Ben Mahler and Vinod Kone.
Repository: mesos
Description
-------
Remove namespace ambiguity. Needed for r37303
Diffs
-----
src/tests/common/http_tests.cpp 38d062b2b4062e0a2fc912bad0cc2d73339eb66e
Diff: https://reviews.apache.org/r/37328/diff/
Testing
-------
make check
Thanks,
Anand Mazumdar