You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@pulsar.apache.org by GitBox <gi...@apache.org> on 2022/09/15 14:59:07 UTC

[GitHub] [pulsar-client-go] labuladong opened a new issue, #846: Suggest rewrite `regexConsumer` with inheritance

labuladong opened a new issue, #846:
URL: https://github.com/apache/pulsar-client-go/issues/846

   I'm working on the batch receive feature #840. But before that, I think simplifying the implementation of `regexConsumer` and `multiTopicConsumer` is necessary.
   
   In Java client, [`PatternMultiTopicsConsumerImpl`](https://github.com/apache/pulsar/blob/15a00137012669b0f6fd869ca5dbdf50898242ac/pulsar-client/src/main/java/org/apache/pulsar/client/impl/PatternMultiTopicsConsumerImpl.java) inherits from [`MultiTopicsConsumerImpl`](https://github.com/apache/pulsar/blob/2d6b534ef72824ffb5b2f76568ca8346bbc058c6/pulsar-client/src/main/java/org/apache/pulsar/client/impl/MultiTopicsConsumerImpl.java). But Go client implements [`multiTopicConsumer`](https://github.com/apache/pulsar-client-go/blob/5108332c9dd4cb454c26804304bffb82eeffc713/pulsar/consumer_multitopic.go#L33) and [`regexConsumer`](https://github.com/apache/pulsar-client-go/blob/5108332c9dd4cb454c26804304bffb82eeffc713/pulsar/consumer_regex.go#L39) separately for now. 
   
   I suggest rewriting [`regexConsumer`](https://github.com/apache/pulsar-client-go/blob/5108332c9dd4cb454c26804304bffb82eeffc713/pulsar/consumer_regex.go#L39) with inheritance just like Java client. If so, further feature development could be easier.
   
   Feel free to correct me if my understanding is inaccurate. cc @wolfstudy @merlimat @nodece 
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

Re: [I] Suggest rewrite `regexConsumer` with inheritance [pulsar-client-go]

Posted by "iamseki (via GitHub)" <gi...@apache.org>.
iamseki commented on issue #846:
URL: https://github.com/apache/pulsar-client-go/issues/846#issuecomment-1743965453

   Any plans to get back to work on the batch receive feature? This seems like a really cool feature but is not available in the Go client :cry: 


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org