You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@zeppelin.apache.org by prabhjyotsingh <gi...@git.apache.org> on 2018/03/05 13:35:18 UTC
[GitHub] zeppelin pull request #2835: [ZEPPELIN-3289] Table not using full height aft...
GitHub user prabhjyotsingh opened a pull request:
https://github.com/apache/zeppelin/pull/2835
[ZEPPELIN-3289] Table not using full height after paragraph height has been changed
### What is this PR for?
Changing paragraph height does not work correctly anymore in conjunction with table output. Refer screen shot:
### What type of PR is it?
[Bug Fix]
### What is the Jira issue?
* [ZEPPELIN-3289](https://issues.apache.org/jira/browse/ZEPPELIN-3289)
* [ZEPPELIN-3272](https://issues.apache.org/jira/browse/ZEPPELIN-3272)
### Questions:
* Does the licenses files need update? N/A
* Is there breaking changes for older versions? N/A
* Does this needs documentation? N/A
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/prabhjyotsingh/zeppelin ZEPPELIN-3289
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/zeppelin/pull/2835.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #2835
----
commit dd6a6d1211d612ab38af7bc279061bfe23430747
Author: Prabhjyot Singh <pr...@...>
Date: 2018-03-05T13:29:19Z
ZEPPELIN-3289: refresh() also updates height
Change-Id: I001421ee174ed2fa06cecfeb845916097fdf1464
----
---
[GitHub] zeppelin issue #2835: [ZEPPELIN-3289] Table not using full height after para...
Posted by weand <gi...@git.apache.org>.
Github user weand commented on the issue:
https://github.com/apache/zeppelin/pull/2835
Opened another table issue with table option 'useFilter' - [ZEPPELIN-3301](https://issues.apache.org/jira/browse/ZEPPELIN-3301).
Probably related to this issue here.
---
[GitHub] zeppelin issue #2835: [ZEPPELIN-3289] Table not using full height after para...
Posted by weand <gi...@git.apache.org>.
Github user weand commented on the issue:
https://github.com/apache/zeppelin/pull/2835
height issue is solved. thanks.
but now got the bahvior, that results are duplicated:
[https://ibin.co/3trkDDqHas5m.gif](https://ibin.co/3trkDDqHas5m.gif)
and the following is logged into console:
`result.controller.js?55cc:685`
```
Graph drawing error TypeError: Cannot read property 'core' of undefined
at TableVisualization.refresh (eval at <anonymous> (app.bundle.js:1968), <anonymous>:172:26)
at TableVisualization.activate (eval at <anonymous> (app.bundle.js:1962), <anonymous>:108:14)
at afterLoaded (eval at <anonymous> (app.bundle.js:2172), <anonymous>:699:31)
at retry (eval at <anonymous> (app.bundle.js:2172), <anonymous>:235:7)
at angular.js:19374
at completeOutstandingRequest (angular.js:5955)
at angular.js:6234
```
---
[GitHub] zeppelin issue #2835: [ZEPPELIN-3289] Table not using full height after para...
Posted by prabhjyotsingh <gi...@git.apache.org>.
Github user prabhjyotsingh commented on the issue:
https://github.com/apache/zeppelin/pull/2835
Have made a fix for both.
---
[GitHub] zeppelin issue #2835: [ZEPPELIN-3289] Table not using full height after para...
Posted by Tagar <gi...@git.apache.org>.
Github user Tagar commented on the issue:
https://github.com/apache/zeppelin/pull/2835
@weand I just logged in https://issues.apache.org/jira/browse/ZEPPELIN-3292 for data duplication )
I don't think it's related to this PR?
---
[GitHub] zeppelin issue #2835: [ZEPPELIN-3289] Table not using full height after para...
Posted by weand <gi...@git.apache.org>.
Github user weand commented on the issue:
https://github.com/apache/zeppelin/pull/2835
LGTM. no errors in console and ZEPPELIN-3292 data duplication fixed as well.
---
[GitHub] zeppelin issue #2835: [ZEPPELIN-3289] Table not using full height after para...
Posted by r-kamath <gi...@git.apache.org>.
Github user r-kamath commented on the issue:
https://github.com/apache/zeppelin/pull/2835
LGTM
---
[GitHub] zeppelin pull request #2835: [ZEPPELIN-3289] Table not using full height aft...
Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:
https://github.com/apache/zeppelin/pull/2835
---
[GitHub] zeppelin issue #2835: [ZEPPELIN-3289] Table not using full height after para...
Posted by prabhjyotsingh <gi...@git.apache.org>.
Github user prabhjyotsingh commented on the issue:
https://github.com/apache/zeppelin/pull/2835
@weand @r-kamath Can you help review this PR.
---
[GitHub] zeppelin issue #2835: [ZEPPELIN-3289] Table not using full height after para...
Posted by prabhjyotsingh <gi...@git.apache.org>.
Github user prabhjyotsingh commented on the issue:
https://github.com/apache/zeppelin/pull/2835
Thanks for the review will merge this if no more discussion.
---
[GitHub] zeppelin issue #2835: [ZEPPELIN-3289] Table not using full height after para...
Posted by prabhjyotsingh <gi...@git.apache.org>.
Github user prabhjyotsingh commented on the issue:
https://github.com/apache/zeppelin/pull/2835
@Tagar This PR fixes [ZEPPELIN-3272](https://issues.apache.org/jira/browse/ZEPPELIN-3272) as well, can you help review this.
---