[GitHub] [nuttx] no1wudi opened a new pull request, #8433: stdio: Make getline() support all EOL case

["no1wudi (via GitHub)" <gi...@apache.org>]

no1wudi opened a new pull request, #8433:
URL: https://github.com/apache/nuttx/pull/8433

   
   
   ## Summary
   By add a new private function getdelimx() that supports delimiter as a sequence or multiple delimiter,
   and forward current getdelim() to it.
   
   For getline(), let it call the new getdelimx() instead of getdlim() to support multiple delimiter.
   ## Impact
   getline() and getdlim
   ## Testing
   WAMR
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [nuttx] no1wudi closed pull request #8433: stdio: Make getline() support all EOL case

["no1wudi (via GitHub)" <gi...@apache.org>]

no1wudi closed pull request #8433: stdio: Make getline() support all EOL case
URL: https://github.com/apache/nuttx/pull/8433


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [nuttx] xiaoxiang781216 commented on a diff in pull request #8433: stdio: Make getline() support all EOL case

["xiaoxiang781216 (via GitHub)" <gi...@apache.org>]

xiaoxiang781216 commented on code in PR #8433:
URL: https://github.com/apache/nuttx/pull/8433#discussion_r1096542488


##########
libs/libc/stdio/lib_getdelim.c:
##########
@@ -33,33 +34,40 @@
  ****************************************************************************/
 
 /* Some environments may return CR as end-of-line, others LF, and others
- * both.  Because of the definition of the getline() function, it can handle
- * only single character line terminators.
+ * both.
  */
 
-#undef HAVE_GETLINE
 #if defined(CONFIG_EOL_IS_CR)

Review Comment:
   can we remove CONFIG_EOL_IS_xxx and convert all possible combination dynamically? 



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org