You are viewing a plain text version of this content. The canonical link for it is here.
Posted to github@arrow.apache.org by "nkarpov (via GitHub)" <gi...@apache.org> on 2023/04/17 14:28:40 UTC
[GitHub] [arrow-datafusion] nkarpov opened a new pull request, #6033: minor feat: impl FromStr for JoinType enum
nkarpov opened a new pull request, #6033:
URL: https://github.com/apache/arrow-datafusion/pull/6033
# Which issue does this PR close?
Closes #.
# Rationale for this change
Adding Python bindings for `join_on` (https://github.com/apache/arrow-datafusion-python/pull/324) causing some code duplication when matching join type. @Jimexist suggested this trait should be implemented instead.
# What changes are included in this PR?
FromStr interface for enum JoinType
# Are these changes tested?
# Are there any user-facing changes?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow-datafusion] alamb commented on pull request #6033: minor feat: impl FromStr for JoinType enum
Posted by "alamb (via GitHub)" <gi...@apache.org>.
alamb commented on PR #6033:
URL: https://github.com/apache/arrow-datafusion/pull/6033#issuecomment-1516257169
Thank you very much @nkarpov and @comphead
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow-datafusion] comphead commented on a diff in pull request #6033: minor feat: impl FromStr for JoinType enum
Posted by "comphead (via GitHub)" <gi...@apache.org>.
comphead commented on code in PR #6033:
URL: https://github.com/apache/arrow-datafusion/pull/6033#discussion_r1169047952
##########
datafusion/expr/src/logical_plan/plan.rs:
##########
@@ -1160,6 +1161,27 @@ impl Display for JoinType {
}
}
+impl FromStr for JoinType {
Review Comment:
Looks good. Thanks for the PR
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow-datafusion] alamb merged pull request #6033: minor feat: impl FromStr for JoinType enum
Posted by "alamb (via GitHub)" <gi...@apache.org>.
alamb merged PR #6033:
URL: https://github.com/apache/arrow-datafusion/pull/6033
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org