You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@kyuubi.apache.org by GitBox <gi...@apache.org> on 2021/11/15 13:54:36 UTC

[GitHub] [incubator-kyuubi] ulysses-you commented on a change in pull request #1391: [KYUUBI #1383] Leverage Scalafmt to auto format scala code

ulysses-you commented on a change in pull request #1391:
URL: https://github.com/apache/incubator-kyuubi/pull/1391#discussion_r749346780



##########
File path: dev/kyuubi-extension-spark-common/src/main/scala/org/apache/kyuubi/sql/KyuubiQueryStagePreparation.scala
##########
@@ -130,12 +132,13 @@ case class FinalStageConfigIsolation(session: SparkSession) extends Rule[SparkPl
           // store the previous config only if we have not stored, to avoid some query only
           // have one stage that will overwrite real config.
           if (!session.sessionState.conf.contains(previousStageConfigKey)) {
-            val originalValue = if (session.conf.getOption(sparkConfigKey).isDefined) {
-              session.sessionState.conf.getConfString(sparkConfigKey)
-            } else {
-              // the default value of config is None, so we need to use a internal tag
-              INTERNAL_UNSET_CONFIG_TAG
-            }
+            val originalValue =

Review comment:
       Does the origin style not good ?




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@kyuubi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org