You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@pulsar.apache.org by GitBox <gi...@apache.org> on 2021/06/21 15:58:16 UTC
[GitHub] [pulsar] mipper opened a new pull request #11006: Update SQL config to use composed contaiiners
mipper opened a new pull request #11006:
URL: https://github.com/apache/pulsar/pull/11006
### Motivation
When we use docker-compose to create multiple service containers we need to override the configuration of each of these containers to use the correct URLs for the other containers running the other Pulsar services. The sql1 container must be configured to use the correct broker, webservice and zookeeper containers.
### Modifications
Added overrides for the above items of the conf/presto/catalog/pulsar.properties file.
See https://apache-pulsar.slack.com/archives/C5Z4T36F7/p1624019944046800
### Verifying this change
- [ ] Make sure that the change passes the CI checks.
This change is a trivial rework / code cleanup without any test coverage.
### Does this pull request potentially affect one of the following parts:
### Documentation
- Does this pull request introduce a new feature? (yes / no)
- If yes, how is the feature documented? (not applicable / docs / JavaDocs / not documented)
- If a feature is not applicable for documentation, explain why?
- If a feature is not documented yet in this PR, please create a followup issue for adding the documentation
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] mipper commented on a change in pull request #11006: Update SQL config to use composed contaiiners
Posted by GitBox <gi...@apache.org>.
mipper commented on a change in pull request #11006:
URL: https://github.com/apache/pulsar/pull/11006#discussion_r660414140
##########
File path: docker-compose/kitchen-sink/docker-compose.yml
##########
@@ -377,6 +377,9 @@ services:
zookeeperServers: zk1:2181,zk2:2181,zk3:2181
configurationStoreServers: zk1:2181,zk2:2181,zk3:2181
pulsar.zookeeper-uri: zk1:2181,zk2:2181,zk3:2181
+ SQL_PREFIX_pulsar.broker-service-url: http://proxy1:8080
Review comment:
@gaoran10 Any feedback on this?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] github-actions[bot] commented on pull request #11006: Update SQL config to use composed contaiiners
Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on pull request #11006:
URL: https://github.com/apache/pulsar/pull/11006#issuecomment-1058889271
@mipper:Thanks for your contribution. For this PR, do we need to update docs?
(The [PR template contains info about doc](https://github.com/apache/pulsar/blob/master/.github/PULL_REQUEST_TEMPLATE.md#documentation), which helps others know more about the changes. Can you provide doc-related info in this and future PR descriptions? Thanks)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] gaoran10 commented on a change in pull request #11006: Update SQL config to use composed contaiiners
Posted by GitBox <gi...@apache.org>.
gaoran10 commented on a change in pull request #11006:
URL: https://github.com/apache/pulsar/pull/11006#discussion_r655842848
##########
File path: docker-compose/kitchen-sink/docker-compose.yml
##########
@@ -377,6 +377,9 @@ services:
zookeeperServers: zk1:2181,zk2:2181,zk3:2181
configurationStoreServers: zk1:2181,zk2:2181,zk3:2181
pulsar.zookeeper-uri: zk1:2181,zk2:2181,zk3:2181
+ SQL_PREFIX_pulsar.broker-service-url: http://proxy1:8080
Review comment:
The configuration `broker-service-url` is deprecated, `web-service-url` instead of it.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] gaoran10 commented on a change in pull request #11006: Update SQL config to use composed contaiiners
Posted by GitBox <gi...@apache.org>.
gaoran10 commented on a change in pull request #11006:
URL: https://github.com/apache/pulsar/pull/11006#discussion_r664435639
##########
File path: docker-compose/kitchen-sink/docker-compose.yml
##########
@@ -377,6 +377,9 @@ services:
zookeeperServers: zk1:2181,zk2:2181,zk3:2181
configurationStoreServers: zk1:2181,zk2:2181,zk3:2181
pulsar.zookeeper-uri: zk1:2181,zk2:2181,zk3:2181
+ SQL_PREFIX_pulsar.broker-service-url: http://proxy1:8080
Review comment:
Sorry late response, I think the config `web-service-url` could replace the config `broker-service-url` completly, if the config `web-service-url` is set, the `broker-service-url` will be useless, refer to https://github.com/apache/pulsar/blob/master/pulsar-sql/presto-pulsar/src/main/java/org/apache/pulsar/sql/presto/PulsarConnectorConfig.java#L90
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] gaoran10 commented on a change in pull request #11006: Update SQL config to use composed contaiiners
Posted by GitBox <gi...@apache.org>.
gaoran10 commented on a change in pull request #11006:
URL: https://github.com/apache/pulsar/pull/11006#discussion_r655842848
##########
File path: docker-compose/kitchen-sink/docker-compose.yml
##########
@@ -377,6 +377,9 @@ services:
zookeeperServers: zk1:2181,zk2:2181,zk3:2181
configurationStoreServers: zk1:2181,zk2:2181,zk3:2181
pulsar.zookeeper-uri: zk1:2181,zk2:2181,zk3:2181
+ SQL_PREFIX_pulsar.broker-service-url: http://proxy1:8080
Review comment:
The configuration `broker-service-url` is deprecated, `web-service-url` will instead of it.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] codelipenghui commented on pull request #11006: Update SQL config to use composed contaiiners
Posted by GitBox <gi...@apache.org>.
codelipenghui commented on pull request #11006:
URL: https://github.com/apache/pulsar/pull/11006#issuecomment-1058889113
The pr had no activity for 30 days, mark with Stale label.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] mipper commented on a change in pull request #11006: Update SQL config to use composed contaiiners
Posted by GitBox <gi...@apache.org>.
mipper commented on a change in pull request #11006:
URL: https://github.com/apache/pulsar/pull/11006#discussion_r656167796
##########
File path: docker-compose/kitchen-sink/docker-compose.yml
##########
@@ -377,6 +377,9 @@ services:
zookeeperServers: zk1:2181,zk2:2181,zk3:2181
configurationStoreServers: zk1:2181,zk2:2181,zk3:2181
pulsar.zookeeper-uri: zk1:2181,zk2:2181,zk3:2181
+ SQL_PREFIX_pulsar.broker-service-url: http://proxy1:8080
Review comment:
But the setting still exists in the image. Either it needs to be removed completely, or it needs to be updated to be valid in the given environment, no? I have assumed it's left in there because it may still be used by something which is why it wasn't removed when it was replaced with the web- alternative.
I'm happy to go either way - remove broker- completely, or keep it and make it correct for this environment. It doesn't seem to make any sense to leave it and have it point to an invalid URL. Which way should I go?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] gaoran10 commented on a change in pull request #11006: Update SQL config to use composed contaiiners
Posted by GitBox <gi...@apache.org>.
gaoran10 commented on a change in pull request #11006:
URL: https://github.com/apache/pulsar/pull/11006#discussion_r655842848
##########
File path: docker-compose/kitchen-sink/docker-compose.yml
##########
@@ -377,6 +377,9 @@ services:
zookeeperServers: zk1:2181,zk2:2181,zk3:2181
configurationStoreServers: zk1:2181,zk2:2181,zk3:2181
pulsar.zookeeper-uri: zk1:2181,zk2:2181,zk3:2181
+ SQL_PREFIX_pulsar.broker-service-url: http://proxy1:8080
Review comment:
The configuration `broker-service-url` is deprecated, `web-service-url` will instead of it.
##########
File path: docker-compose/kitchen-sink/docker-compose.yml
##########
@@ -377,6 +377,9 @@ services:
zookeeperServers: zk1:2181,zk2:2181,zk3:2181
configurationStoreServers: zk1:2181,zk2:2181,zk3:2181
pulsar.zookeeper-uri: zk1:2181,zk2:2181,zk3:2181
+ SQL_PREFIX_pulsar.broker-service-url: http://proxy1:8080
+ SQL_PREFIX_pulsar.web-service-url: http://proxy1:8080
+ SQL_PREFIX_pulsar.zookeeper-uri: zk1:2181
Review comment:
The prefix `SQL_PREFIX_` is not needed, it's only be used to add a new configuration to the config file.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] mipper commented on a change in pull request #11006: Update SQL config to use composed contaiiners
Posted by GitBox <gi...@apache.org>.
mipper commented on a change in pull request #11006:
URL: https://github.com/apache/pulsar/pull/11006#discussion_r660414140
##########
File path: docker-compose/kitchen-sink/docker-compose.yml
##########
@@ -377,6 +377,9 @@ services:
zookeeperServers: zk1:2181,zk2:2181,zk3:2181
configurationStoreServers: zk1:2181,zk2:2181,zk3:2181
pulsar.zookeeper-uri: zk1:2181,zk2:2181,zk3:2181
+ SQL_PREFIX_pulsar.broker-service-url: http://proxy1:8080
Review comment:
@gaoran10 Any feedback on this?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] mipper commented on pull request #11006: Update SQL config to use composed contaiiners
Posted by GitBox <gi...@apache.org>.
mipper commented on pull request #11006:
URL: https://github.com/apache/pulsar/pull/11006#issuecomment-1058977565
There is no requirement to change any documentation as this change is a bug fix that makes an existing feature work correctly. There usage instructions for the amended script have been updates in the PR.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] gaoran10 commented on a change in pull request #11006: Update SQL config to use composed contaiiners
Posted by GitBox <gi...@apache.org>.
gaoran10 commented on a change in pull request #11006:
URL: https://github.com/apache/pulsar/pull/11006#discussion_r655842912
##########
File path: docker-compose/kitchen-sink/docker-compose.yml
##########
@@ -377,6 +377,9 @@ services:
zookeeperServers: zk1:2181,zk2:2181,zk3:2181
configurationStoreServers: zk1:2181,zk2:2181,zk3:2181
pulsar.zookeeper-uri: zk1:2181,zk2:2181,zk3:2181
+ SQL_PREFIX_pulsar.broker-service-url: http://proxy1:8080
+ SQL_PREFIX_pulsar.web-service-url: http://proxy1:8080
+ SQL_PREFIX_pulsar.zookeeper-uri: zk1:2181
Review comment:
The prefix `SQL_PREFIX_` is not needed, it's only be used to add a new configuration to the config file.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] gaoran10 commented on a change in pull request #11006: Update SQL config to use composed contaiiners
Posted by GitBox <gi...@apache.org>.
gaoran10 commented on a change in pull request #11006:
URL: https://github.com/apache/pulsar/pull/11006#discussion_r664435639
##########
File path: docker-compose/kitchen-sink/docker-compose.yml
##########
@@ -377,6 +377,9 @@ services:
zookeeperServers: zk1:2181,zk2:2181,zk3:2181
configurationStoreServers: zk1:2181,zk2:2181,zk3:2181
pulsar.zookeeper-uri: zk1:2181,zk2:2181,zk3:2181
+ SQL_PREFIX_pulsar.broker-service-url: http://proxy1:8080
Review comment:
Sorry late response, I think the config `web-service-url` could replace the config `broker-service-url` completly, if the config `web-service-url` is set, the `broker-service-url` will be useless, refer to https://github.com/apache/pulsar/blob/master/pulsar-sql/presto-pulsar/src/main/java/org/apache/pulsar/sql/presto/PulsarConnectorConfig.java#L90
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org