You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@cloudstack.apache.org by GitBox <gi...@apache.org> on 2021/02/18 13:52:41 UTC
[GitHub] [cloudstack] GutoVeronezi opened a new pull request #4704: Improve logs on kvmvmactivity.sh
GutoVeronezi opened a new pull request #4704:
URL: https://github.com/apache/cloudstack/pull/4704
### Description
This PR intends to improve logging in the file `kvmvmactivity.sh` to facilitate troubleshooting.
### Types of changes
- [ ] Breaking change (fix or feature that would cause existing functionality to change)
- [ ] New feature (non-breaking change which adds functionality)
- [ ] Bug fix (non-breaking change which fixes an issue)
- [x] Enhancement (improves an existing feature and functioanlity)
- [ ] Cleanup (Code refactoring and cleanup, that may add test cases)
### Feature/Enhancement Scale or Bug Severity
#### Feature/Enhancement Scale
- [ ] Major
- [x] Minor
### How Has This Been Tested?
It has been tested locally on a test lab.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] GutoVeronezi commented on pull request #4704: Improve logs on kvmvmactivity.sh
Posted by GitBox <gi...@apache.org>.
GutoVeronezi commented on pull request #4704:
URL: https://github.com/apache/cloudstack/pull/4704#issuecomment-825888750
@rhtyd can you take a look at it?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #4704: Improve logs on kvmvmactivity.sh
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #4704:
URL: https://github.com/apache/cloudstack/pull/4704#issuecomment-794192540
Packaging result: :heavy_check_mark: centos7 :heavy_check_mark: centos8 :heavy_check_mark: debian. SL-JID 65
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] rhtyd commented on a change in pull request #4704: Improve logs on kvmvmactivity.sh
Posted by GitBox <gi...@apache.org>.
rhtyd commented on a change in pull request #4704:
URL: https://github.com/apache/cloudstack/pull/4704#discussion_r588859695
##########
File path: scripts/vm/hypervisor/kvm/kvmvmactivity.sh
##########
@@ -93,7 +93,7 @@ fi
if [ -z "$UUIDList" ]
then
- echo "=====> DEAD <======"
+ echo "=====> Considering host as DEAD due to empty UUIDList <======"
Review comment:
You may want to check if we grep/use the stdout of the script anywhere, otherwise this will cause regression.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] rhtyd commented on pull request #4704: Improve logs on kvmvmactivity.sh
Posted by GitBox <gi...@apache.org>.
rhtyd commented on pull request #4704:
URL: https://github.com/apache/cloudstack/pull/4704#issuecomment-836958806
4.15.1 is the priority right now for me, I'm not looking into master/4.16 specific PRs now. However, I could have been given chance to reply before merging this @DaanHoogland
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #4704: Improve logs on kvmvmactivity.sh
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #4704:
URL: https://github.com/apache/cloudstack/pull/4704#issuecomment-794794995
<b>[S] Trillian test result (tid-65)</b>
Environment: kvm-centos7 (x2), Advanced Networking with Mgmt server 7
Total time taken: 32452 seconds
Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr4704-t65-kvm-centos7.zip
Smoke tests completed. 86 look OK, 0 have error(s)
Only failed tests results shown below:
Test | Result | Time (s) | Test File
--- | --- | --- | ---
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] GutoVeronezi commented on a change in pull request #4704: Improve logs on kvmvmactivity.sh
Posted by GitBox <gi...@apache.org>.
GutoVeronezi commented on a change in pull request #4704:
URL: https://github.com/apache/cloudstack/pull/4704#discussion_r590519769
##########
File path: scripts/vm/hypervisor/kvm/kvmvmactivity.sh
##########
@@ -93,7 +93,7 @@ fi
if [ -z "$UUIDList" ]
then
- echo "=====> DEAD <======"
+ echo "=====> Considering host as DEAD due to empty UUIDList <======"
Review comment:
On KVMHAVMActivityChecker.java we verify if the stdout `contains` `DEAD`. As the keyword `DEAD` still exists in the stdout, it will keep the same behavior.
https://github.com/apache/cloudstack/blob/59fba4916b5c52ca5b3101faaa0f43498201644b/plugins/hypervisors/kvm/src/main/java/com/cloud/hypervisor/kvm/resource/KVMHAVMActivityChecker.java#L59
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] DaanHoogland merged pull request #4704: Improve logs on kvmvmactivity.sh
Posted by GitBox <gi...@apache.org>.
DaanHoogland merged pull request #4704:
URL: https://github.com/apache/cloudstack/pull/4704
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] GutoVeronezi commented on pull request #4704: Improve logs on kvmvmactivity.sh
Posted by GitBox <gi...@apache.org>.
GutoVeronezi commented on pull request #4704:
URL: https://github.com/apache/cloudstack/pull/4704#issuecomment-836748378
@rhtyd can you take a look at this?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org