You are viewing a plain text version of this content. The canonical link for it is here.
Posted to general@incubator.apache.org by Dan Smith <up...@gmail.com> on 2016/04/18 21:08:04 UTC
[VOTE] Release Apache Geode (incubating) 1.0.0-incubating.M2
Hello Incubator PMC,
This is a call for a vote on the Apache Geode (incubating) release
1.0.0-incubating.M2.
This release candidate, 1.0.0-incubating.M2.RC2, has successfully passed a
vote for a release
on the geode developer mailing list.
Vote thread:
http://mail-archives.apache.org/mod_mbox/incubator-geode-dev/201604.mbox/%3CCAFh%2B7k12K%2B2G%2BbPktOwrSs-9CFc_W2%2BKS%3DyE%2BxTXt_AFfjeQWQ%40mail.gmail.com%3E
Results:
http://mail-archives.apache.org/mod_mbox/incubator-geode-dev/201604.mbox/%3CCAFh%2B7k1Bm0XstRZexAUhket1k3sKeP_vMP5T%2Bmrr7QV1j7-t9Q%40mail.gmail.com%3E
It fixes the following issues:
https://issues.apache.org/jira/secure/ReleaseNote.jspa?projectId=12318420&version=12334709
Release candidate tag:
rel/v1.0.0-incubating.M2.RC2
https://git-wip-us.apache.org/repos/asf?p=incubator-geode.git;a=tag;h=refs/tags/rel/v1.0.0-incubating.M2.RC2
Commit ID: 3ac74a4e2c72677ef7c85df77922c645c7cce598
https://git-wip-us.apache.org/repos/asf?p=incubator-geode.git;a=commit;h=3ac74a4e2c72677ef7c85df77922c645c7cce598
Source and binary files:
https://dist.apache.org/repos/dist/dev/incubator/geode/1.0.0-incubating.M2.RC2/
Maven staging repo:
https://repository.apache.org/content/repositories/orgapachegeode-1004/
Geode's KEYS file containing PGP keys we use to sign the release:
https://git-wip-us.apache.org/repos/asf?p=incubator-geode.git;a=blob_plain;f=KEYS;hb=refs/heads/release/1.0.0-incubating.M2
Release Key: pub 4096R/A1688D97 2016-01-20
Fingerprint: 1776 0439 68F0 FD83 62C7 2CCF 444C 1D20 A168 8D97
Please vote on releasing this package as Apache Geode 1.0.0-incubating.M2:
This vote will be open for 72 hours.
[ ] +1 approve
[ ] +0 no opinion
[ ] -1 disapprove (and reason why)
Thanks!
Dan on behalf of the Apache Geode (incubating) team
Re: [VOTE] Release Apache Geode (incubating) 1.0.0-incubating.M2
Posted by Anthony Baker <ab...@pivotal.io>.
Thanks for the feedback Justin!
> On Apr 19, 2016, at 7:14 PM, Justin Mclean <ju...@classsoftware.com> wrote:
>
> Hi,
>
> +1 binding
>
> I checked:
> - incubating in name
> - signatures correct
> - DISCLAIMER exits
> - source LICENSE has some minor issues (see below)
> - source NOICE is good
> - several JS files are missing Apache headers
> - no unexpected binary files in source release
> - can compile from source
>
> Source license minor issues:
> - MIT licensed [1], note that this file also contains MIT licensed MooTools framework
GEODE-1263
> - This file [3] is under MX4J license, I think this should be mentioned in LICENSE and also NOTICE as it’s similar to Apache's 1.1 license.
GEODE-1264. Looks like it got dropped in a merge conflict when the LICENSE was being reworked.
> - The Droid fonts [5] are Apache licensed, but it’s not obvious as they are binary files, so may be good to mention that in LICENSE.
>
GEODE-1265
> For the binary as above and:
> - binary NOTICE some text can be removed (e.g. for the spring projects if you read what you’ve included they tell what text should be included)
> - binary NOTICE no need to mention the name and copyright of the most of the bundled Apache projects
GEODE-1276. (I’m still uncertain if there is consensus regarding listing of bundled ASF projects in the NOTICE)
> - didn’t check full contents but brief heck showed no issues.
>
> Other minor things:
> - A number of ASF licensed files are copyright "Clearspring Technologies, Inc.” (for example) [2] should they be copyright ASF?
The source for ./geode-core/src/main/java/com/gemstone/gemfire/internal/hll/* come from the stream-lib project. The source files state copyright Clearspring but their NOTICE says copyright AddThis.
> - This file still has a Pivotal copyright and patent notice [4]
GEODE-1266
> - The year is incorrect in a number of NOTICE files having "Copyright (c) 2002-2015 Pivotal, Inc.” or "Copyright (c) [2012-2014] Pivotal Software, Inc.”
>
These copyright dates come from the NOTICE in Spring libraries we bundle.
> Thanks,
> Justin
>
> 1. ./geode-pulse/src/main/webapp/scripts/lib/jit.js
> 2. ./geode-core/src/main/java/com/gemstone/gemfire/internal/hll/Bits.java
> 3. ./geode-core/src/main/java/com/gemstone/gemfire/admin/jmx/internal/MX4JModelMBean.java
> 4 .
> 5. ./geode-pulse/src/main/webapp/css/fonts/DroidSans-Bold-webfont.* and DroidSans-webfont.*
>
>
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: general-unsubscribe@incubator.apache.org
> For additional commands, e-mail: general-help@incubator.apache.org
>
Re: [VOTE] Release Apache Geode (incubating) 1.0.0-incubating.M2
Posted by Justin Mclean <ju...@classsoftware.com>.
Hi,
+1 binding
I checked:
- incubating in name
- signatures correct
- DISCLAIMER exits
- source LICENSE has some minor issues (see below)
- source NOICE is good
- several JS files are missing Apache headers
- no unexpected binary files in source release
- can compile from source
Source license minor issues:
- MIT licensed [1], note that this file also contains MIT licensed MooTools framework
- This file [3] is under MX4J license, I think this should be mentioned in LICENSE and also NOTICE as it’s similar to Apache's 1.1 license.
- The Droid fonts [5] are Apache licensed, but it’s not obvious as they are binary files, so may be good to mention that in LICENSE.
For the binary as above and:
- binary NOTICE some text can be removed (e.g. for the spring projects if you read what you’ve included they tell what text should be included)
- binary NOTICE no need to mention the name and copyright of the most of the bundled Apache projects
- didn’t check full contents but brief heck showed no issues.
Other minor things:
- A number of ASF licensed files are copyright "Clearspring Technologies, Inc.” (for example) [2] should they be copyright ASF?
- This file still has a Pivotal copyright and patent notice [4]
- The year is incorrect in a number of NOTICE files having "Copyright (c) 2002-2015 Pivotal, Inc.” or "Copyright (c) [2012-2014] Pivotal Software, Inc.”
Thanks,
Justin
1. ./geode-pulse/src/main/webapp/scripts/lib/jit.js
2. ./geode-core/src/main/java/com/gemstone/gemfire/internal/hll/Bits.java
3. ./geode-core/src/main/java/com/gemstone/gemfire/admin/jmx/internal/MX4JModelMBean.java
4 ./geode-cq/src/test/java/com/gemstone/gemfire/internal/cache/RemoteCQTransactionDUnitTest.java
5. ./geode-pulse/src/main/webapp/css/fonts/DroidSans-Bold-webfont.* and DroidSans-webfont.*
---------------------------------------------------------------------
To unsubscribe, e-mail: general-unsubscribe@incubator.apache.org
For additional commands, e-mail: general-help@incubator.apache.org
Re: [VOTE] Release Apache Geode (incubating) 1.0.0-incubating.M2
Posted by Roman Shaposhnik <ro...@shaposhnik.org>.
On Mon, Apr 18, 2016 at 12:08 PM, Dan Smith <up...@gmail.com> wrote:
> Hello Incubator PMC,
>
> This is a call for a vote on the Apache Geode (incubating) release
> 1.0.0-incubating.M2.
>
> This release candidate, 1.0.0-incubating.M2.RC2, has successfully passed a
> vote for a release
> on the geode developer mailing list.
>
> Vote thread:
> http://mail-archives.apache.org/mod_mbox/incubator-geode-dev/201604.mbox/%3CCAFh%2B7k12K%2B2G%2BbPktOwrSs-9CFc_W2%2BKS%3DyE%2BxTXt_AFfjeQWQ%40mail.gmail.com%3E
>
> Results:
> http://mail-archives.apache.org/mod_mbox/incubator-geode-dev/201604.mbox/%3CCAFh%2B7k1Bm0XstRZexAUhket1k3sKeP_vMP5T%2Bmrr7QV1j7-t9Q%40mail.gmail.com%3E
>
> It fixes the following issues:
> https://issues.apache.org/jira/secure/ReleaseNote.jspa?projectId=12318420&version=12334709
>
> Release candidate tag:
> rel/v1.0.0-incubating.M2.RC2
> https://git-wip-us.apache.org/repos/asf?p=incubator-geode.git;a=tag;h=refs/tags/rel/v1.0.0-incubating.M2.RC2
>
> Commit ID: 3ac74a4e2c72677ef7c85df77922c645c7cce598
> https://git-wip-us.apache.org/repos/asf?p=incubator-geode.git;a=commit;h=3ac74a4e2c72677ef7c85df77922c645c7cce598
>
> Source and binary files:
> https://dist.apache.org/repos/dist/dev/incubator/geode/1.0.0-incubating.M2.RC2/
>
> Maven staging repo:
> https://repository.apache.org/content/repositories/orgapachegeode-1004/
>
> Geode's KEYS file containing PGP keys we use to sign the release:
> https://git-wip-us.apache.org/repos/asf?p=incubator-geode.git;a=blob_plain;f=KEYS;hb=refs/heads/release/1.0.0-incubating.M2
>
> Release Key: pub 4096R/A1688D97 2016-01-20
> Fingerprint: 1776 0439 68F0 FD83 62C7 2CCF 444C 1D20 A168 8D97
>
> Please vote on releasing this package as Apache Geode 1.0.0-incubating.M2:
>
> This vote will be open for 72 hours.
>
> [ ] +1 approve
> [ ] +0 no opinion
> [ ] -1 disapprove (and reason why)
+1 (binding)
Checked:
* hashes and signatures
* DISCLAIMER, NOTICE (nit: you don't have to mention Solr) and
LICENSE in the source tarball(s)
* DISCLAIMER, NOTICE and LICENSE in the bianry convenience artifact
* RAT check and RAT exclusions in ./gradle/rat.gradle all check out
* compared the content of the archive to the TAG
* basic build works (and it works on ARM64 arch -- that's the one I
had handy with Java 8 ;-))
NOTE: that anybody who wants to build this release has to run
gradlew or have at least
Gradle 2.8 installed on their system. I filed a bug on that
https://issues.apache.org/jira/browse/GEODE-1259
Finally, I'd like to applaud the podling for maitaining an amazing
release documentation:
https://cwiki.apache.org/confluence/display/GEODE/Release+proccess
I wish all podlings had a page like that!
Thanks,
Roman.
---------------------------------------------------------------------
To unsubscribe, e-mail: general-unsubscribe@incubator.apache.org
For additional commands, e-mail: general-help@incubator.apache.org
Re: [VOTE] Release Apache Geode (incubating) 1.0.0-incubating.M2
Posted by Dan Smith <up...@gmail.com>.
Thanks!
I filed GEODE-1271 for the sha256 issues.
-Dan
On Thu, Apr 21, 2016 at 3:34 PM, Konstantin Boudnik <co...@apache.org> wrote:
> +1 [biding]
>
> Signature is good
> sha256 is good
> release tar content matches the commit
> build works out of the source code
>
> Minor stuff on top of Justin's detailed analysis:
> - suffix for sha256 file is better be sha256, looks confusing otherwise
> - the file itself isn't properly formatted, which prevents automatic
> checksum
> validation with 'sha256sum -c'
> - make sure to have your keys signed by others, so they are a part of
> wider
> WOT
>
> Cos
>
> On Mon, Apr 18, 2016 at 12:08PM, Dan Smith wrote:
> > Hello Incubator PMC,
> >
> > This is a call for a vote on the Apache Geode (incubating) release
> > 1.0.0-incubating.M2.
> >
> > This release candidate, 1.0.0-incubating.M2.RC2, has successfully passed
> a
> > vote for a release
> > on the geode developer mailing list.
> >
> > Vote thread:
> >
> http://mail-archives.apache.org/mod_mbox/incubator-geode-dev/201604.mbox/%3CCAFh%2B7k12K%2B2G%2BbPktOwrSs-9CFc_W2%2BKS%3DyE%2BxTXt_AFfjeQWQ%40mail.gmail.com%3E
> >
> > Results:
> >
> http://mail-archives.apache.org/mod_mbox/incubator-geode-dev/201604.mbox/%3CCAFh%2B7k1Bm0XstRZexAUhket1k3sKeP_vMP5T%2Bmrr7QV1j7-t9Q%40mail.gmail.com%3E
> >
> > It fixes the following issues:
> >
> https://issues.apache.org/jira/secure/ReleaseNote.jspa?projectId=12318420&version=12334709
> >
> > Release candidate tag:
> > rel/v1.0.0-incubating.M2.RC2
> >
> https://git-wip-us.apache.org/repos/asf?p=incubator-geode.git;a=tag;h=refs/tags/rel/v1.0.0-incubating.M2.RC2
> >
> > Commit ID: 3ac74a4e2c72677ef7c85df77922c645c7cce598
> >
> https://git-wip-us.apache.org/repos/asf?p=incubator-geode.git;a=commit;h=3ac74a4e2c72677ef7c85df77922c645c7cce598
> >
> > Source and binary files:
> >
> https://dist.apache.org/repos/dist/dev/incubator/geode/1.0.0-incubating.M2.RC2/
> >
> > Maven staging repo:
> > https://repository.apache.org/content/repositories/orgapachegeode-1004/
> >
> > Geode's KEYS file containing PGP keys we use to sign the release:
> >
> https://git-wip-us.apache.org/repos/asf?p=incubator-geode.git;a=blob_plain;f=KEYS;hb=refs/heads/release/1.0.0-incubating.M2
> >
> > Release Key: pub 4096R/A1688D97 2016-01-20
> > Fingerprint: 1776 0439 68F0 FD83 62C7 2CCF 444C 1D20 A168 8D97
> >
> > Please vote on releasing this package as Apache Geode
> 1.0.0-incubating.M2:
> >
> > This vote will be open for 72 hours.
> >
> > [ ] +1 approve
> > [ ] +0 no opinion
> > [ ] -1 disapprove (and reason why)
> >
> > Thanks!
> > Dan on behalf of the Apache Geode (incubating) team
>
Re: [VOTE] Release Apache Geode (incubating) 1.0.0-incubating.M2
Posted by Konstantin Boudnik <co...@apache.org>.
+1 [biding]
Signature is good
sha256 is good
release tar content matches the commit
build works out of the source code
Minor stuff on top of Justin's detailed analysis:
- suffix for sha256 file is better be sha256, looks confusing otherwise
- the file itself isn't properly formatted, which prevents automatic checksum
validation with 'sha256sum -c'
- make sure to have your keys signed by others, so they are a part of wider
WOT
Cos
On Mon, Apr 18, 2016 at 12:08PM, Dan Smith wrote:
> Hello Incubator PMC,
>
> This is a call for a vote on the Apache Geode (incubating) release
> 1.0.0-incubating.M2.
>
> This release candidate, 1.0.0-incubating.M2.RC2, has successfully passed a
> vote for a release
> on the geode developer mailing list.
>
> Vote thread:
> http://mail-archives.apache.org/mod_mbox/incubator-geode-dev/201604.mbox/%3CCAFh%2B7k12K%2B2G%2BbPktOwrSs-9CFc_W2%2BKS%3DyE%2BxTXt_AFfjeQWQ%40mail.gmail.com%3E
>
> Results:
> http://mail-archives.apache.org/mod_mbox/incubator-geode-dev/201604.mbox/%3CCAFh%2B7k1Bm0XstRZexAUhket1k3sKeP_vMP5T%2Bmrr7QV1j7-t9Q%40mail.gmail.com%3E
>
> It fixes the following issues:
> https://issues.apache.org/jira/secure/ReleaseNote.jspa?projectId=12318420&version=12334709
>
> Release candidate tag:
> rel/v1.0.0-incubating.M2.RC2
> https://git-wip-us.apache.org/repos/asf?p=incubator-geode.git;a=tag;h=refs/tags/rel/v1.0.0-incubating.M2.RC2
>
> Commit ID: 3ac74a4e2c72677ef7c85df77922c645c7cce598
> https://git-wip-us.apache.org/repos/asf?p=incubator-geode.git;a=commit;h=3ac74a4e2c72677ef7c85df77922c645c7cce598
>
> Source and binary files:
> https://dist.apache.org/repos/dist/dev/incubator/geode/1.0.0-incubating.M2.RC2/
>
> Maven staging repo:
> https://repository.apache.org/content/repositories/orgapachegeode-1004/
>
> Geode's KEYS file containing PGP keys we use to sign the release:
> https://git-wip-us.apache.org/repos/asf?p=incubator-geode.git;a=blob_plain;f=KEYS;hb=refs/heads/release/1.0.0-incubating.M2
>
> Release Key: pub 4096R/A1688D97 2016-01-20
> Fingerprint: 1776 0439 68F0 FD83 62C7 2CCF 444C 1D20 A168 8D97
>
> Please vote on releasing this package as Apache Geode 1.0.0-incubating.M2:
>
> This vote will be open for 72 hours.
>
> [ ] +1 approve
> [ ] +0 no opinion
> [ ] -1 disapprove (and reason why)
>
> Thanks!
> Dan on behalf of the Apache Geode (incubating) team
Re: [VOTE] Release Apache Geode (incubating) 1.0.0-incubating.M2
Posted by Dan Smith <up...@gmail.com>.
Looks like we still need one more binding vote on this release. Could
someone please take a look and vote?
Thanks!
-Dan
On Mon, Apr 18, 2016 at 12:08 PM, Dan Smith <up...@gmail.com>
wrote:
> Hello Incubator PMC,
>
> This is a call for a vote on the Apache Geode (incubating) release
> 1.0.0-incubating.M2.
>
> This release candidate, 1.0.0-incubating.M2.RC2, has successfully passed a
> vote for a release
> on the geode developer mailing list.
>
> Vote thread:
>
> http://mail-archives.apache.org/mod_mbox/incubator-geode-dev/201604.mbox/%3CCAFh%2B7k12K%2B2G%2BbPktOwrSs-9CFc_W2%2BKS%3DyE%2BxTXt_AFfjeQWQ%40mail.gmail.com%3E
>
> Results:
>
> http://mail-archives.apache.org/mod_mbox/incubator-geode-dev/201604.mbox/%3CCAFh%2B7k1Bm0XstRZexAUhket1k3sKeP_vMP5T%2Bmrr7QV1j7-t9Q%40mail.gmail.com%3E
>
> It fixes the following issues:
>
> https://issues.apache.org/jira/secure/ReleaseNote.jspa?projectId=12318420&version=12334709
>
> Release candidate tag:
> rel/v1.0.0-incubating.M2.RC2
>
> https://git-wip-us.apache.org/repos/asf?p=incubator-geode.git;a=tag;h=refs/tags/rel/v1.0.0-incubating.M2.RC2
>
> Commit ID: 3ac74a4e2c72677ef7c85df77922c645c7cce598
>
> https://git-wip-us.apache.org/repos/asf?p=incubator-geode.git;a=commit;h=3ac74a4e2c72677ef7c85df77922c645c7cce598
>
> Source and binary files:
>
> https://dist.apache.org/repos/dist/dev/incubator/geode/1.0.0-incubating.M2.RC2/
>
> Maven staging repo:
> https://repository.apache.org/content/repositories/orgapachegeode-1004/
>
> Geode's KEYS file containing PGP keys we use to sign the release:
>
> https://git-wip-us.apache.org/repos/asf?p=incubator-geode.git;a=blob_plain;f=KEYS;hb=refs/heads/release/1.0.0-incubating.M2
>
> Release Key: pub 4096R/A1688D97 2016-01-20
> Fingerprint: 1776 0439 68F0 FD83 62C7 2CCF 444C 1D20 A168 8D97
>
> Please vote on releasing this package as Apache Geode 1.0.0-incubating.M2:
>
> This vote will be open for 72 hours.
>
> [ ] +1 approve
> [ ] +0 no opinion
> [ ] -1 disapprove (and reason why)
>
> Thanks!
> Dan on behalf of the Apache Geode (incubating) team
>