[GitHub] [hive] pgaref commented on a change in pull request #983: HIVE-23215. Make FilterContext an interface.

[GitBox <gi...@apache.org>]

pgaref commented on a change in pull request #983: HIVE-23215. Make FilterContext an interface.
URL: https://github.com/apache/hive/pull/983#discussion_r409416250
 
 

 ##########
 File path: storage-api/src/java/org/apache/hadoop/hive/ql/exec/vector/VectorizedRowBatch.java
 ##########
 @@ -359,4 +361,62 @@ public void ensureSize(int rows) {
       cols[i].ensureSize(rows, false);
     }
 
 Review comment:
   Should we call updateSelected(rows) here as well?
   According to getMaxSize() method, selected array should be able to hold the max number of rows.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: gitbox-unsubscribe@hive.apache.org
For additional commands, e-mail: gitbox-help@hive.apache.org