You are viewing a plain text version of this content. The canonical link for it is here.

Posted to commits@mynewt.apache.org by GitBox <gi...@apache.org> on 2019/04/29 07:15:28 UTC

[GitHub] [mynewt-nimble] sjanc commented on a change in pull request #419: nimble/gap: Allow reconfiguration of the same adv instance and remove it when receiving adv set terminate event from LL.

sjanc commented on a change in pull request #419: nimble/gap: Allow reconfiguration of the same adv instance and remove it when receiving adv set terminate event from LL.
URL: https://github.com/apache/mynewt-nimble/pull/419#discussion_r279254375
 
 

 ##########
 File path: nimble/host/src/ble_gap.c
 ##########
 @@ -2520,12 +2524,6 @@ ble_gap_ext_adv_configure(uint8_t instance,
 
     ble_hs_lock();
 
-    /* TODO should we allow to reconfigure existing instance? */
-    if (ble_gap_slave[instance].configured) {
 
 Review comment:
   I don't think we should allow to reconfigure active instance, should this be checked here?

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services