You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@superset.apache.org by GitBox <gi...@apache.org> on 2018/11/06 08:09:47 UTC
[GitHub] kristw commented on a change in pull request #6283: [dashboard] fix
spinners disappear too early
kristw commented on a change in pull request #6283: [dashboard] fix <Loading /> spinners disappear too early
URL: https://github.com/apache/incubator-superset/pull/6283#discussion_r231027942
##########
File path: superset/assets/src/chart/Chart.jsx
##########
@@ -176,7 +176,7 @@ class Chart extends React.PureComponent {
>
{this.renderTooltip()}
- {isLoading && <Loading size={50} />}
+ {chartStatus !== 'rendered' && <Loading size={50} />}
Review comment:
How about updating the definition of `isLoading` on line 164?
**from**
```js
const isLoading = chartStatus === 'loading';
```
**to**
```js
const isLoading = chartStatus !== 'rendered';
```
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org