You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@druid.apache.org by "GWphua (via GitHub)" <gi...@apache.org> on 2024/09/16 10:11:03 UTC
[PR] Remove UseG1GC in cluster/auto to prevent multiple GC declared Error (druid)
GWphua opened a new pull request, #17078:
URL: https://github.com/apache/druid/pull/17078
### Description
This problem surfaced when I am attempting to get MM-less Druid running on ZGC with Kubernetes. After declaring `-XX:+UseZGC` under `JAVA_OPTS` for my services, I faced the following error for only the Coordinator, Overlord and Router:
"Error occurred during initialization of VM, Multiple garbage collectors selected". It turns out that the declaration of the G1GC in the cluster configuration causes the error to surface. I also find it weird that this G1GC configuration is only in the Coordinator/Overlord and Router configuration. By removing the G1GC configuration, I am able to run my cluster with ZGC.
#### Fixed the multiple GC declared error.
#### Release note
<!-- Give your best effort to summarize your changes in a couple of sentences aimed toward Druid users.
If your change doesn't have end user impact, you can skip this section.
For tips about how to write a good release note, see [Release notes](https://github.com/apache/druid/blob/master/CONTRIBUTING.md#release-notes).
-->
<hr>
##### Allow Druid to run non-G1 Garbage Collectors with `JAVA_OPTS`.
<hr>
<!-- Check the items by putting "x" in the brackets for the done things. Not all of these items apply to every PR. Remove the items which are not done or not relevant to the PR. None of the items from the checklist below are strictly necessary, but it would be very helpful if you at least self-review the PR. -->
This PR has:
- [x] been self-reviewed.
- [x] been tested in a test Druid cluster.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@druid.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@druid.apache.org
For additional commands, e-mail: commits-help@druid.apache.org
Re: [PR] Fix Multiple GC declared error when running Druid Cluster (druid)
Posted by "kgyrtkirk (via GitHub)" <gi...@apache.org>.
kgyrtkirk commented on PR #17078:
URL: https://github.com/apache/druid/pull/17078#issuecomment-2363235819
Thank you @GWphua for fixing this!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@druid.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@druid.apache.org
For additional commands, e-mail: commits-help@druid.apache.org
Re: [PR] Fix Multiple GC declared error when running Druid Cluster (druid)
Posted by "kgyrtkirk (via GitHub)" <gi...@apache.org>.
kgyrtkirk merged PR #17078:
URL: https://github.com/apache/druid/pull/17078
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@druid.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@druid.apache.org
For additional commands, e-mail: commits-help@druid.apache.org
Re: [PR] Fix Multiple GC declared error when running Druid Cluster (druid)
Posted by "kgyrtkirk (via GitHub)" <gi...@apache.org>.
kgyrtkirk commented on PR #17078:
URL: https://github.com/apache/druid/pull/17078#issuecomment-2357705875
note: there is no need to force push the branch as merge will be done with a squash (don't rebase your downstream branch)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@druid.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@druid.apache.org
For additional commands, e-mail: commits-help@druid.apache.org
Re: [PR] Fix Multiple GC declared error when running Druid Cluster (druid)
Posted by "kgyrtkirk (via GitHub)" <gi...@apache.org>.
kgyrtkirk commented on code in PR #17078:
URL: https://github.com/apache/druid/pull/17078#discussion_r1764540295
##########
examples/conf/druid/single-server/small/router/jvm.config:
##########
@@ -1,10 +1,8 @@
-server
-Xms512m
-Xmx512m
--XX:+UseG1GC
-XX:MaxDirectMemorySize=128m
-XX:+ExitOnOutOfMemoryError
--XX:+UseG1GC
Review Comment:
lol :)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@druid.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@druid.apache.org
For additional commands, e-mail: commits-help@druid.apache.org
Re: [PR] Fix Multiple GC declared error when running Druid Cluster (druid)
Posted by "kgyrtkirk (via GitHub)" <gi...@apache.org>.
kgyrtkirk commented on PR #17078:
URL: https://github.com/apache/druid/pull/17078#issuecomment-2355385025
I think the default configs should not set such a thing - unless its really beneficial.
I haven't seen any measurements/etc why this was set initially in the commit logs
Its mentioned in https://druid.apache.org/docs/latest/operations/basic-cluster-tuning/ ; it seems like it was added as a suggestion in [this PR](https://github.com/apache/druid/pull/7629).
I looked at `-XX` flags being set in the files below `examples`:
* `-XX:+ExitOnOutOfMemoryError` looks reasonable :)
* `-XX:MaxDirectMemorySize` seems okay as well
* `-XX:+UseG1GC` (this)
I agree that the GC algo selection should be removed - as its important to ship something which works out of the box with the least amount of issues.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@druid.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@druid.apache.org
For additional commands, e-mail: commits-help@druid.apache.org
Re: [PR] Fix Multiple GC declared error when running Druid Cluster (druid)
Posted by "GWphua (via GitHub)" <gi...@apache.org>.
GWphua commented on PR #17078:
URL: https://github.com/apache/druid/pull/17078#issuecomment-2357409325
@kgyrtkirk Thanks for the quick reply. I have removed the declaration in all files under `examples`.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@druid.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@druid.apache.org
For additional commands, e-mail: commits-help@druid.apache.org
Re: [PR] Fix Multiple GC declared error when running Druid Cluster (druid)
Posted by "kgyrtkirk (via GitHub)" <gi...@apache.org>.
kgyrtkirk commented on PR #17078:
URL: https://github.com/apache/druid/pull/17078#issuecomment-2355388323
would you like to remove `G1GC` from other files under `examples` ?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@druid.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@druid.apache.org
For additional commands, e-mail: commits-help@druid.apache.org
Re: [PR] Fix Multiple GC declared error when running Druid Cluster (druid)
Posted by "GWphua (via GitHub)" <gi...@apache.org>.
GWphua commented on PR #17078:
URL: https://github.com/apache/druid/pull/17078#issuecomment-2360556048
hi @kgyrtkirk
Thanks for approving my PR, can I trouble you to merge this PR now that the CI has passed? 😄
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@druid.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@druid.apache.org
For additional commands, e-mail: commits-help@druid.apache.org