You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@hawq.apache.org by xunzhang <gi...@git.apache.org> on 2016/09/20 09:25:59 UTC
[GitHub] incubator-hawq pull request #919: HAWQ-1061. Add check_sizes_valid for all m...
GitHub user xunzhang opened a pull request:
https://github.com/apache/incubator-hawq/pull/919
HAWQ-1061. Add check_sizes_valid for all mode of hawq register.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/xunzhang/incubator-hawq hotfix
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/incubator-hawq/pull/919.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #919
----
commit 77aa508be1aae3aa8b7eb7b24d11bf9c63aa2f4c
Author: xunzhang <xu...@gmail.com>
Date: 2016-09-20T09:25:22Z
HAWQ-1061. Add check_sizes_valid for all mode of hawq register.
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-hawq pull request #919: HAWQ-1061. Add check_sizes_valid for all m...
Posted by ictmalili <gi...@git.apache.org>.
Github user ictmalili commented on a diff in the pull request:
https://github.com/apache/incubator-hawq/pull/919#discussion_r79571607
--- Diff: tools/bin/hawqregister ---
@@ -397,6 +397,14 @@ class HawqRegister(object):
logger.info('%s is not a file in hdfs, please check the yaml configuration file.' % fn)
sys.exit(1)
+ def check_sizes_valid():
+ for k, fn in enumerate(self.files):
+ hdfscmd = 'hdfs dfs -du %s' % fn
+ _, out, _ = local_ssh_output(hdfscmd)
+ if self.sizes[k] > int(out.strip().split()[0]):
+ logger.error('Incorrect filesize %s in yaml of file %s: out of range %s' % (self.sizes[k], fn, out.strip().split()[0]))
--- End diff --
File size(%s) in yaml configuration file should not exceed actual length(%s) of file %s
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-hawq issue #919: HAWQ-1061. Add check_sizes_valid for all mode of ...
Posted by stanlyxiang <gi...@git.apache.org>.
Github user stanlyxiang commented on the issue:
https://github.com/apache/incubator-hawq/pull/919
+1
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-hawq issue #919: HAWQ-1061. Add check_sizes_valid for all mode of ...
Posted by xunzhang <gi...@git.apache.org>.
Github user xunzhang commented on the issue:
https://github.com/apache/incubator-hawq/pull/919
cc @ictmalili @linwen
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-hawq issue #919: HAWQ-1061. Add check_sizes_valid for all mode of ...
Posted by xunzhang <gi...@git.apache.org>.
Github user xunzhang commented on the issue:
https://github.com/apache/incubator-hawq/pull/919
also cc @stanlyxiang
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-hawq issue #919: HAWQ-1061. Add check_sizes_valid for all mode of ...
Posted by xunzhang <gi...@git.apache.org>.
Github user xunzhang commented on the issue:
https://github.com/apache/incubator-hawq/pull/919
Merged into master.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-hawq pull request #919: HAWQ-1061. Add check_sizes_valid for all m...
Posted by xunzhang <gi...@git.apache.org>.
Github user xunzhang commented on a diff in the pull request:
https://github.com/apache/incubator-hawq/pull/919#discussion_r79574274
--- Diff: tools/bin/hawqregister ---
@@ -397,6 +397,14 @@ class HawqRegister(object):
logger.info('%s is not a file in hdfs, please check the yaml configuration file.' % fn)
sys.exit(1)
+ def check_sizes_valid():
+ for k, fn in enumerate(self.files):
+ hdfscmd = 'hdfs dfs -du %s' % fn
+ _, out, _ = local_ssh_output(hdfscmd)
+ if self.sizes[k] > int(out.strip().split()[0]):
+ logger.error('Incorrect filesize %s in yaml of file %s: out of range %s' % (self.sizes[k], fn, out.strip().split()[0]))
--- End diff --
@ictmalili done
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-hawq pull request #919: HAWQ-1061. Add check_sizes_valid for all m...
Posted by xunzhang <gi...@git.apache.org>.
Github user xunzhang closed the pull request at:
https://github.com/apache/incubator-hawq/pull/919
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-hawq issue #919: HAWQ-1061. Add check_sizes_valid for all mode of ...
Posted by ictmalili <gi...@git.apache.org>.
Github user ictmalili commented on the issue:
https://github.com/apache/incubator-hawq/pull/919
+1
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---