You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@ignite.apache.org by "AMashenkov (via GitHub)" <gi...@apache.org> on 2023/06/30 09:23:09 UTC
[GitHub] [ignite-3] AMashenkov opened a new pull request, #2274: IGNITE-19892 Fix catalog module dependencies
AMashenkov opened a new pull request, #2274:
URL: https://github.com/apache/ignite-3/pull/2274
https://issues.apache.org/jira/browse/IGNITE-19892
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@ignite.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [ignite-3] AMashenkov commented on pull request #2274: IGNITE-19892 Fix catalog module dependencies
Posted by "AMashenkov (via GitHub)" <gi...@apache.org>.
AMashenkov commented on PR #2274:
URL: https://github.com/apache/ignite-3/pull/2274#issuecomment-1614390750
This refactoring is required to pass CatalogManager into various components, which should subscribe to catalog events.
As for now, I've no clue how to resolve few weird dependencies because of component configuration classes structure, like:
storage-api -> distribution-zones, distribution-zones -> schema
I hope with will be fixed after https://issues.apache.org/jira/browse/IGNITE-19752
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@ignite.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [ignite-3] AMashenkov merged pull request #2274: IGNITE-19892 Fix catalog module dependencies
Posted by "AMashenkov (via GitHub)" <gi...@apache.org>.
AMashenkov merged PR #2274:
URL: https://github.com/apache/ignite-3/pull/2274
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@ignite.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [ignite-3] korlov42 commented on a diff in pull request #2274: IGNITE-19892 Fix catalog module dependencies
Posted by "korlov42 (via GitHub)" <gi...@apache.org>.
korlov42 commented on code in PR #2274:
URL: https://github.com/apache/ignite-3/pull/2274#discussion_r1250391461
##########
modules/distribution-zones/build.gradle:
##########
@@ -26,6 +26,7 @@ dependencies {
annotationProcessor project(":ignite-configuration-annotation-processor")
annotationProcessor libs.auto.service
+ implementation project(':ignite-catalog')
Review Comment:
why do we need this dependency? I would postpone introducing any dependency till the moment whet it actually required
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@ignite.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org