You are viewing a plain text version of this content. The canonical link for it is here.
Posted to github@arrow.apache.org by GitBox <gi...@apache.org> on 2022/02/01 14:10:51 UTC

[GitHub] [arrow-rs] alamb opened a new issue #1255: Fix all clippy lints in arrow crate

alamb opened a new issue #1255:
URL: https://github.com/apache/arrow-rs/issues/1255


   **Describe the bug**
   Due to "historical reasons" there are several clippy lints that are disabled in the `arrow` crate
   https://github.com/apache/arrow-rs/blob/master/arrow/src/lib.rs#L130-L141
   
   ```rust
   #![allow(dead_code)]
   #![allow(non_camel_case_types)]
   #![deny(clippy::redundant_clone)]
   #![allow(
       // introduced to ignore lint errors when upgrading from 2020-04-22 to 2020-11-14
       clippy::float_equality_without_abs,
       clippy::type_complexity,
       // upper_case_acronyms lint was introduced in Rust 1.51.
       // It is triggered in the ffi module, and ipc::gen, which we have no control over
       clippy::upper_case_acronyms,
       clippy::vec_init_then_push
   )]
   ```
   
   It would be great to clean up the code to pass these lints for tidiness
   
   **To Reproduce**
   Remove one of the `#[allow]` lines above, run `clippy`
   
   **Expected behavior**
   Clippy runs cleanly without blank `#allow` across the whole crate
   
   **Additional context**
   Add any other context about the problem here.
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [arrow-rs] alamb commented on issue #1255: Fix all clippy lints in arrow crate

Posted by GitBox <gi...@apache.org>.
alamb commented on issue #1255:
URL: https://github.com/apache/arrow-rs/issues/1255#issuecomment-1037224816


   Thanks @gsserge  that would be great!


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [arrow-rs] gsserge commented on issue #1255: Fix all clippy lints in arrow crate

Posted by GitBox <gi...@apache.org>.
gsserge commented on issue #1255:
URL: https://github.com/apache/arrow-rs/issues/1255#issuecomment-1037215519


   I'd like to work on this one. One PR per lint rule should make it easier to review and integrate.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [arrow-rs] gsserge commented on issue #1255: Fix all clippy lints in arrow crate

Posted by GitBox <gi...@apache.org>.
gsserge commented on issue #1255:
URL: https://github.com/apache/arrow-rs/issues/1255#issuecomment-1037215519


   I'd like to work on this one. One PR per lint rule should make it easier to review and integrate.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [arrow-rs] alamb commented on issue #1255: Fix all clippy lints in arrow crate

Posted by GitBox <gi...@apache.org>.
alamb commented on issue #1255:
URL: https://github.com/apache/arrow-rs/issues/1255#issuecomment-1037224816


   Thanks @gsserge  that would be great!


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [arrow-rs] alamb closed issue #1255: Fix all clippy lints in arrow crate

Posted by GitBox <gi...@apache.org>.
alamb closed issue #1255:
URL: https://github.com/apache/arrow-rs/issues/1255


   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org