You are viewing a plain text version of this content. The canonical link for it is here.

Posted to dev@felix.apache.org by "Christian Schneider (JIRA)" <ji...@apache.org> on 2015/04/09 19:03:12 UTC

[jira] [Created] (FELIX-4848) Split ResolverImpl

Christian Schneider created FELIX-4848:
------------------------------------------

             Summary: Split ResolverImpl
                 Key: FELIX-4848
                 URL: https://issues.apache.org/jira/browse/FELIX-4848
             Project: Felix
          Issue Type: Improvement
          Components: Resolver
    Affects Versions: resolver-1.0.0
            Reporter: Christian Schneider
             Fix For: resolver-1.2.0


ResolverImpl currently contains about 2300 lines of code. That is way too big for a single class.

I looked into it and found that the checkDynamicPackageSpaceConsistency and checkPackageSpaceConsistency methods and their dependent methods form a nice subset. I would move that into a class ConsistencyCheck.

Both would share all of the inner classes of ResolverImpl but nothing else. 
So I think i would make sense to move these inner classes to separate files.

These changes should nicely split the classes into 
ResolverImpl : 1400 lines
ConsistencyCheck : 600 lines




--
This message was sent by Atlassian JIRA
(v6.3.4#6332)