You are viewing a plain text version of this content. The canonical link for it is here.

Posted to reviews@iotdb.apache.org by GitBox <gi...@apache.org> on 2020/10/19 05:47:26 UTC

[GitHub] [iotdb] JackieTien97 commented on a change in pull request #1821: [IOTDB-926] Support reconnection of Session

JackieTien97 commented on a change in pull request #1821:
URL: https://github.com/apache/iotdb/pull/1821#discussion_r507482485



##########
File path: session/src/main/java/org/apache/iotdb/session/Session.java
##########
@@ -239,7 +244,15 @@ public void insertTablet(Tablet tablet, boolean sorted)
     try {
       RpcUtils.verifySuccess(client.insertTablet(request));
     } catch (TException e) {
-      throw new IoTDBConnectionException(e);
+      if (reconnect()) {

Review comment:
       It seems that the open() doesn't call the reconnect(), there won't be any infinite loops.




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org