[jira] [Closed] (COUCHDB-1344) add etap coverage for _changes with filters and since

["Joan Touzet (JIRA)" <ji...@apache.org>]

     [ https://issues.apache.org/jira/browse/COUCHDB-1344?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Joan Touzet closed COUCHDB-1344.
--------------------------------
    Resolution: Fixed

etap is done. If you want to implement this in eunit please reopen and edit description

> add etap coverage for _changes with filters and since
> -----------------------------------------------------
>
>                 Key: COUCHDB-1344
>                 URL: https://issues.apache.org/jira/browse/COUCHDB-1344
>             Project: CouchDB
>          Issue Type: Improvement
>          Components: Database Core, Test Suite
>    Affects Versions: 1.2
>            Reporter: Randall Leeds
>            Assignee: Randall Leeds
>            Priority: Minor
>
> I described a problem with the js tests for _changes after new filtering stuff:
>   > It was the "andmore-only" section near the end:
>   > T(line.seq == 8)
>   > T(line.id == "andmore")
>   > The problem is that seq _should_ be strictly greater than since.
>   > If you look at couch_db:changes_since/5 and related functions, that
>   > module adds one to the sequence number in order to get this behavior.
>   > Only when using filters was this broken and became >=.
> Filipe said:
>   > I've never had such failure locally. If it's due to browser caching,
>   > it would be a good idea to add a test to test/etap/073-changes.t
> I said I'd add an etap test. This ticket is to remind me to do it:
>   > I can add an etap test. I'm positive it's not browser caching because
>   > I identified and fixed it. Also, because I just committed a change to
>   > improve Futon's browser caching :).



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)