You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@ofbiz.apache.org by "Patrick Antivackis (JIRA)" <ji...@apache.org> on 2009/06/18 22:00:07 UTC
[jira] Updated: (OFBIZ-2628) No Url encoding for get parameters
[ https://issues.apache.org/jira/browse/OFBIZ-2628?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Patrick Antivackis updated OFBIZ-2628:
--------------------------------------
Description:
Let's say I want to create a new category which ID is DVD+R
Creation is ok through the admin interface, but whenever i want to access this category, the get parameter productCategoryId=.... of the url is wrong as it's not url encoded, so we have :
https://localhost:8443/catalog/control/EditCategory?productCategoryId=DVD+R instead of
https://localhost:8443/catalog/control/EditCategory?productCategoryId=DVD%2BR
Both <@ofbizUrl> tag and menu widgets are not encoding get parameters.
Way to correct :
framework/webapp/src/org/ofbiz/webapp/control/RequestHandler.java modify the makeLink function
framework/widget/src/org/ofbiz/widget/WidgetWorker.java : function buildhyperlinkUrl need to use defaultWebEncoder.encodeForURL instead of simpleEncoder
Beofre i do the fix, can a core developper let me know about possible side effects
was:
Let's say I want to create a new category which ID is DVD+R
Creation is ok through the admin interface, but whenever i want to access this category, the get parameter productCategoryId=.... of the url is wrong as it's not url encoded, so we have :
https://localhost:8443/catalog/control/EditCategory?productCategoryId=DVD+R instead of
https://localhost:8443/catalog/control/EditCategory?productCategoryId=DVD%2BR
Both <@ofbizUrl> tag and menu widgets are not encoding get parameters.
Way to correct :
framework/webapp/src/org/ofbiz/webapp/control/RequestHandler.java modify the makeLink function
framework/widget/src/org/ofbiz/widget/WidgetWorker.java : need to use defaultWebEncoder.encodeForURL instead of simpleEncoder
Beofre i do the fix, can a core developper let me know about possible side effects
> No Url encoding for get parameters
> ----------------------------------
>
> Key: OFBIZ-2628
> URL: https://issues.apache.org/jira/browse/OFBIZ-2628
> Project: OFBiz
> Issue Type: Bug
> Components: framework
> Affects Versions: Release Branch 4.0, Release Branch 9.04, SVN trunk
> Environment: All
> Reporter: Patrick Antivackis
> Priority: Critical
> Original Estimate: 4h
> Remaining Estimate: 4h
>
> Let's say I want to create a new category which ID is DVD+R
> Creation is ok through the admin interface, but whenever i want to access this category, the get parameter productCategoryId=.... of the url is wrong as it's not url encoded, so we have :
> https://localhost:8443/catalog/control/EditCategory?productCategoryId=DVD+R instead of
> https://localhost:8443/catalog/control/EditCategory?productCategoryId=DVD%2BR
> Both <@ofbizUrl> tag and menu widgets are not encoding get parameters.
> Way to correct :
> framework/webapp/src/org/ofbiz/webapp/control/RequestHandler.java modify the makeLink function
> framework/widget/src/org/ofbiz/widget/WidgetWorker.java : function buildhyperlinkUrl need to use defaultWebEncoder.encodeForURL instead of simpleEncoder
> Beofre i do the fix, can a core developper let me know about possible side effects
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.