[GitHub] [metron] mmiklavc commented on issue #1546: METRON-2239 Metron Automated backup and restore

[GitBox <gi...@apache.org>]

mmiklavc commented on issue #1546: METRON-2239 Metron Automated backup and restore
URL: https://github.com/apache/metron/pull/1546#issuecomment-548057601
 
 
   @ottobackwards - I ran shellcheck and modified some exit codes. Other than that, it's warnings about shell expansion on variables, which we also have all over in other scripts. I think it should be good to go from that perspective.
   
   WRT added instructions for the upgrade, I've debated where these belong. With the ES upgrade we placed instructions right in the module - https://github.com/apache/metron/blob/b9a130ca96774add38865d3934ed61ca19599b87/metron-platform/metron-elasticsearch/metron-elasticsearch-common/README.md#upgrading-from-233-to-56. We have an existing `Upgrading` document - https://github.com/apache/metron/blob/b9a130ca96774add38865d3934ed61ca19599b87/Upgrading.md, however this is primarily some line items with pointers to other details. What do you think about adding a new README in the project root named something like`Upgrade_steps.md`? In master, we'd start with the existing backup/restore process outline. For the HDP 3.1 feature branch, I'd expand out those details to include things like specifying that we need to upgrade from Centos 6 to 7.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services