You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@camel.apache.org by "aldettinger (via GitHub)" <gi...@apache.org> on 2023/03/28 15:08:43 UTC
[GitHub] [camel-quarkus] aldettinger opened a new pull request, #4708: Camel quarkus 4658
aldettinger opened a new pull request, #4708:
URL: https://github.com/apache/camel-quarkus/pull/4708
<!-- Uncomment and fill this section if your PR is not trivial
[ ] An issue should be filed for the change unless this is a trivial change (fixing a typo or similar). One issue should ideally be fixed by not more than one commit and the other way round, each commit should fix just one issue, without pulling in other changes.
[ ] Each commit in the pull request should have a meaningful and properly spelled subject line and body. Copying the title of the associated issue is typically enough. Please include the issue number in the commit message prefixed by #.
[ ] The pull request description should explain what the pull request does, how, and why. If the info is available in the associated issue or some other external document, a link is enough.
[ ] Phrases like Fix #<issueNumber> or Fixes #<issueNumber> will auto-close the named issue upon merging the pull request. Using them is typically a good idea.
[ ] Please run mvn process-resources -Pformat (and amend the changes if necessary) before sending the pull request.
[ ] Contributor guide is your good friend: https://camel.apache.org/camel-quarkus/latest/contributor-guide.html
-->
The commits are still separated with hope to provide easier review.
Ideally, we would squash them before merging for simpler backporting in 2.13.x.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [camel-quarkus] jamesnetherton commented on a diff in pull request #4708: CQ-4658: Complete vertx-http test coverage
Posted by "jamesnetherton (via GitHub)" <gi...@apache.org>.
jamesnetherton commented on code in PR #4708:
URL: https://github.com/apache/camel-quarkus/pull/4708#discussion_r1151614640
##########
docs/modules/ROOT/pages/reference/extensions/vertx-http.adoc:
##########
@@ -55,3 +55,25 @@ You will also need to enable serialization for the exception classes that you in
----
@RegisterForReflection(targets = { IllegalStateException.class, MyCustomException.class }, serialization = true)
----
+
+[id="extensions-vertx-http-additional-camel-quarkus-configuration"]
+== Additional Camel Quarkus configuration
+
+[id="extensions-vertx-http-configuration-allowjavaserializedobject-option-in-native-mode"]
+== allowJavaSerializedObject option in native mode
+
+When using the `allowJavaSerializedObject` option in native mode, the support of serialization might need to be enabled.
+Please, refer to the xref:user-guide/native-mode.adoc#serialization[native mode user guide] for more information.
+
+Some classes are registered https://github.com/apache/camel-quarkus/blob/main/extensions-core/core/deployment/src/main/java/org/apache/camel/quarkus/core/deployment/CamelSerializationProcessor.java[by default].
+In case another class is to be serialized, then explicit registration as below might be needed:
+[source,java]
+----
+@RegisterForReflection(targets = { MyCustomContent.class }, serialization = true)
Review Comment:
> So that we could remove line 68 -> 72
Yes, it's a bit of a duplication of what's already in the native mode guide.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [camel-quarkus] aldettinger merged pull request #4708: Complete vertx-http test coverage #4658
Posted by "aldettinger (via GitHub)" <gi...@apache.org>.
aldettinger merged PR #4708:
URL: https://github.com/apache/camel-quarkus/pull/4708
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [camel-quarkus] aldettinger commented on a diff in pull request #4708: CQ-4658: Complete vertx-http test coverage
Posted by "aldettinger (via GitHub)" <gi...@apache.org>.
aldettinger commented on code in PR #4708:
URL: https://github.com/apache/camel-quarkus/pull/4708#discussion_r1151585765
##########
docs/modules/ROOT/pages/reference/extensions/vertx-http.adoc:
##########
@@ -55,3 +55,25 @@ You will also need to enable serialization for the exception classes that you in
----
@RegisterForReflection(targets = { IllegalStateException.class, MyCustomException.class }, serialization = true)
----
+
+[id="extensions-vertx-http-additional-camel-quarkus-configuration"]
+== Additional Camel Quarkus configuration
+
+[id="extensions-vertx-http-configuration-allowjavaserializedobject-option-in-native-mode"]
+== allowJavaSerializedObject option in native mode
+
+When using the `allowJavaSerializedObject` option in native mode, the support of serialization might need to be enabled.
+Please, refer to the xref:user-guide/native-mode.adoc#serialization[native mode user guide] for more information.
+
+Some classes are registered https://github.com/apache/camel-quarkus/blob/main/extensions-core/core/deployment/src/main/java/org/apache/camel/quarkus/core/deployment/CamelSerializationProcessor.java[by default].
+In case another class is to be serialized, then explicit registration as below might be needed:
+[source,java]
+----
+@RegisterForReflection(targets = { MyCustomContent.class }, serialization = true)
Review Comment:
That's a good point. Maybe it's redundant with https://camel.apache.org/camel-quarkus/2.16.x/user-guide/native-mode.html#serialization ? So that we could remove line 68 -> 72 ?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [camel-quarkus] aldettinger commented on a diff in pull request #4708: CQ-4658: Complete vertx-http test coverage
Posted by "aldettinger (via GitHub)" <gi...@apache.org>.
aldettinger commented on code in PR #4708:
URL: https://github.com/apache/camel-quarkus/pull/4708#discussion_r1151653055
##########
docs/modules/ROOT/pages/reference/extensions/vertx-http.adoc:
##########
@@ -55,3 +55,25 @@ You will also need to enable serialization for the exception classes that you in
----
@RegisterForReflection(targets = { IllegalStateException.class, MyCustomException.class }, serialization = true)
----
+
+[id="extensions-vertx-http-additional-camel-quarkus-configuration"]
+== Additional Camel Quarkus configuration
+
+[id="extensions-vertx-http-configuration-allowjavaserializedobject-option-in-native-mode"]
+== allowJavaSerializedObject option in native mode
+
+When using the `allowJavaSerializedObject` option in native mode, the support of serialization might need to be enabled.
+Please, refer to the xref:user-guide/native-mode.adoc#serialization[native mode user guide] for more information.
+
+Some classes are registered https://github.com/apache/camel-quarkus/blob/main/extensions-core/core/deployment/src/main/java/org/apache/camel/quarkus/core/deployment/CamelSerializationProcessor.java[by default].
+In case another class is to be serialized, then explicit registration as below might be needed:
+[source,java]
+----
+@RegisterForReflection(targets = { MyCustomContent.class }, serialization = true)
Review Comment:
ok, it's fixed.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [camel-quarkus] aldettinger commented on pull request #4708: Complete vertx-http test coverage #4658
Posted by "aldettinger (via GitHub)" <gi...@apache.org>.
aldettinger commented on PR #4708:
URL: https://github.com/apache/camel-quarkus/pull/4708#issuecomment-1488471980
Many thanks for review. Failing tests are not related. Squashing/merging then.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [camel-quarkus] zbendhiba commented on a diff in pull request #4708: CQ-4658: Complete vertx-http test coverage
Posted by "zbendhiba (via GitHub)" <gi...@apache.org>.
zbendhiba commented on code in PR #4708:
URL: https://github.com/apache/camel-quarkus/pull/4708#discussion_r1151525499
##########
docs/modules/ROOT/pages/reference/extensions/vertx-http.adoc:
##########
@@ -55,3 +55,25 @@ You will also need to enable serialization for the exception classes that you in
----
@RegisterForReflection(targets = { IllegalStateException.class, MyCustomException.class }, serialization = true)
----
+
+[id="extensions-vertx-http-additional-camel-quarkus-configuration"]
+== Additional Camel Quarkus configuration
+
+[id="extensions-vertx-http-configuration-allowjavaserializedobject-option-in-native-mode"]
+== allowJavaSerializedObject option in native mode
+
+When using the `allowJavaSerializedObject` option in native mode, the support of serialization might need to be enabled.
+Please, refer to the xref:user-guide/native-mode.adoc#serialization[native mode user guide] for more information.
+
+Some classes are registered https://github.com/apache/camel-quarkus/blob/main/extensions-core/core/deployment/src/main/java/org/apache/camel/quarkus/core/deployment/CamelSerializationProcessor.java[by default].
+In case another class is to be serialized, then explicit registration as below might be needed:
+[source,java]
+----
+@RegisterForReflection(targets = { MyCustomContent.class }, serialization = true)
Review Comment:
Do we need an example for this ?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org