You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@lucene.apache.org by "Cao Manh Dat (JIRA)" <ji...@apache.org> on 2016/10/08 02:48:20 UTC
[jira] [Comment Edited] (SOLR-1113) Error reports from
ExtractingRequestHandler and Co do not indicate name of rejected documents
[ https://issues.apache.org/jira/browse/SOLR-1113?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15556987#comment-15556987 ]
Cao Manh Dat edited comment on SOLR-1113 at 10/8/16 2:48 AM:
-------------------------------------------------------------
In my own opinion. What happen here is when user do a multipart request to upload a file and the length of the request exceed multipartUploadLimitInKB. Under the hood when we read the header of the request, we found the "Content-Length" exceed the limit, so we will stop handle the request and throw out an exception, so we don't have a chance to look down for all file names of the request to print out a precise error. I think this is correct behavior because we do not want a user to upload whole the file and get an error about exceed file upload limit. So this is kinda a problem related to user behavior, they must check whether the request is successful or not ( moreover the update process can throw a lot of different kind of exception, so they have to catch problem all the time )
Because of that, I think we can close this issue as won't fix.
was (Author: caomanhdat):
In my own opinion. What happen here is when user do a multipart request to upload a file and the length of the request exceed multipartUploadLimitInKB. Under the hood when we read the header of the request, we found the "Content-Length" exceed the limit, so we will stop handle the request and throw out an exception, so we don't have a chance to look down for all file names of the request to print out a precise error. I think this is correct behavior because we do not want a user to upload whole the file and get an error about exceed file upload limit. So this is kinda a problem related to user behavior, they must check whether the request is successful or not.
Because of that, I think we can close this issue as won't fix.
> Error reports from ExtractingRequestHandler and Co do not indicate name of rejected documents
> ---------------------------------------------------------------------------------------------
>
> Key: SOLR-1113
> URL: https://issues.apache.org/jira/browse/SOLR-1113
> Project: Solr
> Issue Type: Improvement
> Components: update
> Reporter: Fergus McMenemie
>
> The ExtractingRequestHandler rejects documents that are larger than the configured multipartUploadLimitInKB in solrconfig.xml. None of the generated error messages indicate the name of the rejected document or provide any way of identifying the rejected document. The failure to identify the rejected document complicates the middleware used to look after indexes.
> Here is the trace produced by a recent version of trunk.
> {code}
> SEVERE: org.apache.commons.fileupload.FileUploadBase$SizeLimitExceededException: the request was rejected because its size (4585774) exceeds the configured maximum (2097152)
> at org.apache.commons.fileupload.FileUploadBase$FileItemIteratorImpl.<init>(FileUploadBase.java:914)
> at org.apache.commons.fileupload.FileUploadBase.getItemIterator(FileUploadBase.java:331)
> at org.apache.commons.fileupload.FileUploadBase.parseRequest(FileUploadBase.java:349)
> at org.apache.commons.fileupload.servlet.ServletFileUpload.parseRequest(ServletFileUpload.java:126)
> at org.apache.solr.servlet.MultipartRequestParser.parseParamsAndFillStreams(SolrRequestParsers.java:343)
> at org.apache.solr.servlet.StandardRequestParser.parseParamsAndFillStreams(SolrRequestParsers.java:396)
> at org.apache.solr.servlet.SolrRequestParsers.parse(SolrRequestParsers.java:114)
> at org.apache.solr.servlet.SolrDispatchFilter.doFilter(SolrDispatchFilter.java:217)
> at org.apache.catalina.core.ApplicationFilterChain.internalDoFilter(ApplicationFilterChain.java:202)
> at org.apache.catalina.core.ApplicationFilterChain.doFilter(ApplicationFilterChain.java:173)
> at org.apache.catalina.core.StandardWrapperValve.invoke(StandardWrapperValve.java:213)
> at org.apache.catalina.core.StandardContextValve.invoke(StandardContextValve.java:178)
> at org.apache.catalina.core.StandardHostValve.invoke(StandardHostValve.java:126)
> at org.apache.catalina.valves.ErrorReportValve.invoke(ErrorReportValve.java:105)
> {code}
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: dev-help@lucene.apache.org