You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@submarine.apache.org by GitBox <gi...@apache.org> on 2020/08/06 06:57:37 UTC

[GitHub] [submarine] lichaonw opened a new pull request #371: reduce duplicate definitions

lichaonw opened a new pull request #371:
URL: https://github.com/apache/submarine/pull/371


   ### What is this PR for?
   reduce duplicate definitions of object in submarine-client, such as:
   
   ```java
   public class ClientContext {
     private Configuration yarnConf = new YarnConfiguration();
   ```
   yarnConf object has been definitions whe we Instantiate ClientContext .
   
   ```java
    if (clientContext.getSubmarineConfig().getBoolean(
           SubmarineConfVars.ConfVars.
             SUBMARINE_SERVER_RPC_ENABLED)) {
         runtimeFactory = new RpcRuntimeFactory(clientContext);
       } else {
         Configuration conf = new YarnConfiguration();
         clientContext.setYarnConfig(conf);
         runtimeFactory = RuntimeFactory.getRuntimeFactory(clientContext,
             Thread.currentThread().getContextClassLoader());
       }
   ```
   it has duplicate definitions, i think it should be remove.
   
   ### What type of PR is it?
   [Refactoring]
   
   ### Todos
   * [ ] - Task
   
   ### What is the Jira issue?
   https://issues.apache.org/jira/browse/SUBMARINE-595
   
   ### How should this be tested?
   
   
   ### Screenshots (if appropriate)
   
   ### Questions:
   * Does the licenses files need update? Yes/No
   * Is there breaking changes for older versions? Yes/No
   * Does this needs documentation? Yes/No
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [submarine] lichaonw commented on pull request #371: SUBMARINE-595. reduce duplicate definitionsreduce duplicate definitions

Posted by GitBox <gi...@apache.org>.
lichaonw commented on pull request #371:
URL: https://github.com/apache/submarine/pull/371#issuecomment-671007336


   ok，i get it


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [submarine] lichaonw closed pull request #371: SUBMARINE-595. reduce duplicate definitionsreduce duplicate definitions

Posted by GitBox <gi...@apache.org>.
lichaonw closed pull request #371:
URL: https://github.com/apache/submarine/pull/371


   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org