You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@continuum.apache.org by "Bj?rn Sk?ld (JIRA)" <ji...@codehaus.org> on 2005/07/17 16:38:57 UTC

[jira] Created: (CONTINUUM-237) Cannot add m1 project, Missing 'groupId'

Cannot add m1 project, Missing 'groupId'
----------------------------------------

         Key: CONTINUUM-237
         URL: http://jira.codehaus.org/browse/CONTINUUM-237
     Project: Continuum
        Type: Bug
  Components: continuum-core  
    Versions: 1.0-beta-1    
 Reporter: Björn Sköld
    Priority: Minor
 Attachments: diff.txt

When adding a m1 project I get the error "Missing 'groupId' element in the POM". The POM does contain a groupId.

The tests for groupId and artifactId in DefaultMavenOneMetadataHelper seem broken.

Note that correcting this probably makes the tests too strict. It should probably be ok 
* to have a POM without groupId
* to use id instead of artifactId

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
   http://jira.codehaus.org/secure/Administrators.jspa
-
For more information on JIRA, see:
   http://www.atlassian.com/software/jira


[jira] Closed: (CONTINUUM-237) Cannot add m1 project, Missing 'groupId'

Posted by "Trygve Laugstol (JIRA)" <ji...@codehaus.org>.
     [ http://jira.codehaus.org/browse/CONTINUUM-237?page=all ]
     
Trygve Laugstol closed CONTINUUM-237:
-------------------------------------

     Resolution: Fixed
    Fix Version: 1.0-beta-1

Done.

> Cannot add m1 project, Missing 'groupId'
> ----------------------------------------
>
>          Key: CONTINUUM-237
>          URL: http://jira.codehaus.org/browse/CONTINUUM-237
>      Project: Continuum
>         Type: Bug
>   Components: continuum-core
>     Versions: 1.0-beta-1
>     Reporter: Björn Sköld
>     Assignee: Trygve Laugstol
>     Priority: Minor
>      Fix For: 1.0-beta-1
>  Attachments: diff.txt
>
>
> When adding a m1 project I get the error "Missing 'groupId' element in the POM". The POM does contain a groupId.
> The tests for groupId and artifactId in DefaultMavenOneMetadataHelper seem broken.
> Note that correcting this probably makes the tests too strict. It should probably be ok 
> * to have a POM without groupId
> * to use id instead of artifactId

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
   http://jira.codehaus.org/secure/Administrators.jspa
-
For more information on JIRA, see:
   http://www.atlassian.com/software/jira


[jira] Assigned: (CONTINUUM-237) Cannot add m1 project, Missing 'groupId'

Posted by "Trygve Laugstol (JIRA)" <ji...@codehaus.org>.
     [ http://jira.codehaus.org/browse/CONTINUUM-237?page=all ]

Trygve Laugstol reassigned CONTINUUM-237:
-----------------------------------------

    Assign To: Trygve Laugstol

> Cannot add m1 project, Missing 'groupId'
> ----------------------------------------
>
>          Key: CONTINUUM-237
>          URL: http://jira.codehaus.org/browse/CONTINUUM-237
>      Project: Continuum
>         Type: Bug
>   Components: continuum-core
>     Versions: 1.0-beta-1
>     Reporter: Björn Sköld
>     Assignee: Trygve Laugstol
>     Priority: Minor
>  Attachments: diff.txt
>
>
> When adding a m1 project I get the error "Missing 'groupId' element in the POM". The POM does contain a groupId.
> The tests for groupId and artifactId in DefaultMavenOneMetadataHelper seem broken.
> Note that correcting this probably makes the tests too strict. It should probably be ok 
> * to have a POM without groupId
> * to use id instead of artifactId

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
   http://jira.codehaus.org/secure/Administrators.jspa
-
For more information on JIRA, see:
   http://www.atlassian.com/software/jira


[jira] Commented: (CONTINUUM-237) Cannot add m1 project, Missing 'groupId'

Posted by "Trygve Laugstol (JIRA)" <ji...@codehaus.org>.
    [ http://jira.codehaus.org/browse/CONTINUUM-237?page=comments#action_42963 ] 

Trygve Laugstol commented on CONTINUUM-237:
-------------------------------------------

Oh, I see that you've already attached a patch. Thanks a bunch!

> Cannot add m1 project, Missing 'groupId'
> ----------------------------------------
>
>          Key: CONTINUUM-237
>          URL: http://jira.codehaus.org/browse/CONTINUUM-237
>      Project: Continuum
>         Type: Bug
>   Components: continuum-core
>     Versions: 1.0-beta-1
>     Reporter: Björn Sköld
>     Assignee: Trygve Laugstol
>     Priority: Minor
>  Attachments: diff.txt
>
>
> When adding a m1 project I get the error "Missing 'groupId' element in the POM". The POM does contain a groupId.
> The tests for groupId and artifactId in DefaultMavenOneMetadataHelper seem broken.
> Note that correcting this probably makes the tests too strict. It should probably be ok 
> * to have a POM without groupId
> * to use id instead of artifactId

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
   http://jira.codehaus.org/secure/Administrators.jspa
-
For more information on JIRA, see:
   http://www.atlassian.com/software/jira


[jira] Commented: (CONTINUUM-237) Cannot add m1 project, Missing 'groupId'

Posted by "Trygve Laugstol (JIRA)" <ji...@codehaus.org>.
    [ http://jira.codehaus.org/browse/CONTINUUM-237?page=comments#action_42962 ] 

Trygve Laugstol commented on CONTINUUM-237:
-------------------------------------------

Broken how? If you could send in a project.xml that shows this problem that would be appreciated.

For your other points
 * to have a POM without groupId
Possibly makes sense for Continuum but I think even Maven 1 requires a groupId. The next version will also make much more use of the grouping information so it makes sense for most projects to have it.

* to use id instead of artifactId
 True, I've already fixed this in my local checkout. Should be in SVN by today.

> Cannot add m1 project, Missing 'groupId'
> ----------------------------------------
>
>          Key: CONTINUUM-237
>          URL: http://jira.codehaus.org/browse/CONTINUUM-237
>      Project: Continuum
>         Type: Bug
>   Components: continuum-core
>     Versions: 1.0-beta-1
>     Reporter: Björn Sköld
>     Assignee: Trygve Laugstol
>     Priority: Minor
>  Attachments: diff.txt
>
>
> When adding a m1 project I get the error "Missing 'groupId' element in the POM". The POM does contain a groupId.
> The tests for groupId and artifactId in DefaultMavenOneMetadataHelper seem broken.
> Note that correcting this probably makes the tests too strict. It should probably be ok 
> * to have a POM without groupId
> * to use id instead of artifactId

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
   http://jira.codehaus.org/secure/Administrators.jspa
-
For more information on JIRA, see:
   http://www.atlassian.com/software/jira