You are viewing a plain text version of this content. The canonical link for it is here.
Posted to github@arrow.apache.org by GitBox <gi...@apache.org> on 2021/12/27 20:36:14 UTC

[GitHub] [arrow-cookbook] tonyfujs opened a new pull request #114: Fix hyperlink

tonyfujs opened a new pull request #114:
URL: https://github.com/apache/arrow-cookbook/pull/114


   Minor edit to fix hyper link at the bottom of the page.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [arrow-cookbook] thisisnic commented on a change in pull request #114: Fix hyperlink

Posted by GitBox <gi...@apache.org>.
thisisnic commented on a change in pull request #114:
URL: https://github.com/apache/arrow-cookbook/pull/114#discussion_r786277495



##########
File path: r/content/arrays.Rmd
##########
@@ -185,4 +185,4 @@ Scalar, Array, and ChunkedArray objects.  The returned object will be an Arrow o
 
 ### See also
 
-For a more in-depth discussion of Arrow compute functions, see the section on (using arrow functions in dplyr verbs in arrow)[#Using-arrow-functions-in-dplyr-verbs-in-arrow]
+For a more in-depth discussion of Arrow compute functions, see the section on [using arrow functions in dplyr verbs in arrow](#Use-arrow-functions-in-dplyr-verbs-in-arrow)

Review comment:
       Thanks for checking that!




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [arrow-cookbook] thisisnic commented on a change in pull request #114: Fix hyperlink

Posted by GitBox <gi...@apache.org>.
thisisnic commented on a change in pull request #114:
URL: https://github.com/apache/arrow-cookbook/pull/114#discussion_r785480563



##########
File path: r/content/arrays.Rmd
##########
@@ -185,4 +185,4 @@ Scalar, Array, and ChunkedArray objects.  The returned object will be an Arrow o
 
 ### See also
 
-For a more in-depth discussion of Arrow compute functions, see the section on (using arrow functions in dplyr verbs in arrow)[#Using-arrow-functions-in-dplyr-verbs-in-arrow]
+For a more in-depth discussion of Arrow compute functions, see the section on (using arrow functions in dplyr verbs in arrow)[#Use-arrow-functions-in-dplyr-verbs-in-arrow]

Review comment:
       Good catch @lidavidm 




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [arrow-cookbook] lidavidm merged pull request #114: Fix hyperlink

Posted by GitBox <gi...@apache.org>.
lidavidm merged pull request #114:
URL: https://github.com/apache/arrow-cookbook/pull/114


   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [arrow-cookbook] thisisnic commented on a change in pull request #114: Fix hyperlink

Posted by GitBox <gi...@apache.org>.
thisisnic commented on a change in pull request #114:
URL: https://github.com/apache/arrow-cookbook/pull/114#discussion_r785480618



##########
File path: r/content/arrays.Rmd
##########
@@ -185,4 +185,4 @@ Scalar, Array, and ChunkedArray objects.  The returned object will be an Arrow o
 
 ### See also
 
-For a more in-depth discussion of Arrow compute functions, see the section on (using arrow functions in dplyr verbs in arrow)[#Using-arrow-functions-in-dplyr-verbs-in-arrow]
+For a more in-depth discussion of Arrow compute functions, see the section on (using arrow functions in dplyr verbs in arrow)[#Use-arrow-functions-in-dplyr-verbs-in-arrow]

Review comment:
       ```suggestion
   For a more in-depth discussion of Arrow compute functions, see the section on [using arrow functions in dplyr verbs in arrow](#Use-arrow-functions-in-dplyr-verbs-in-arrow)
   ```




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [arrow-cookbook] lidavidm commented on pull request #114: Fix hyperlink

Posted by GitBox <gi...@apache.org>.
lidavidm commented on pull request #114:
URL: https://github.com/apache/arrow-cookbook/pull/114#issuecomment-1015461577


   Thanks @tonyfujs!


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [arrow-cookbook] lidavidm commented on a change in pull request #114: Fix hyperlink

Posted by GitBox <gi...@apache.org>.
lidavidm commented on a change in pull request #114:
URL: https://github.com/apache/arrow-cookbook/pull/114#discussion_r778876256



##########
File path: r/content/arrays.Rmd
##########
@@ -185,4 +185,4 @@ Scalar, Array, and ChunkedArray objects.  The returned object will be an Arrow o
 
 ### See also
 
-For a more in-depth discussion of Arrow compute functions, see the section on (using arrow functions in dplyr verbs in arrow)[#Using-arrow-functions-in-dplyr-verbs-in-arrow]
+For a more in-depth discussion of Arrow compute functions, see the section on (using arrow functions in dplyr verbs in arrow)[#Use-arrow-functions-in-dplyr-verbs-in-arrow]

Review comment:
       Thanks for this.
   
   Shouldn't the link syntax be `[]()` not `()[]`? Also, should it link to `tables.html#Use-...`?




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [arrow-cookbook] lidavidm commented on a change in pull request #114: Fix hyperlink

Posted by GitBox <gi...@apache.org>.
lidavidm commented on a change in pull request #114:
URL: https://github.com/apache/arrow-cookbook/pull/114#discussion_r786057619



##########
File path: r/content/arrays.Rmd
##########
@@ -185,4 +185,4 @@ Scalar, Array, and ChunkedArray objects.  The returned object will be an Arrow o
 
 ### See also
 
-For a more in-depth discussion of Arrow compute functions, see the section on (using arrow functions in dplyr verbs in arrow)[#Using-arrow-functions-in-dplyr-verbs-in-arrow]
+For a more in-depth discussion of Arrow compute functions, see the section on [using arrow functions in dplyr verbs in arrow](#Use-arrow-functions-in-dplyr-verbs-in-arrow)

Review comment:
       ```suggestion
   For a more in-depth discussion of Arrow compute functions, see the section on [using arrow functions in dplyr verbs in arrow](#use-arrow-functions-in-dplyr-verbs-in-arrow)
   ```

##########
File path: r/content/arrays.Rmd
##########
@@ -185,4 +185,4 @@ Scalar, Array, and ChunkedArray objects.  The returned object will be an Arrow o
 
 ### See also
 
-For a more in-depth discussion of Arrow compute functions, see the section on (using arrow functions in dplyr verbs in arrow)[#Using-arrow-functions-in-dplyr-verbs-in-arrow]
+For a more in-depth discussion of Arrow compute functions, see the section on [using arrow functions in dplyr verbs in arrow](#Use-arrow-functions-in-dplyr-verbs-in-arrow)

Review comment:
       I built it locally and it seems the link is still broken - the autogenerated section reference is case-sensitive.




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org