You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@xerces.apache.org by mr...@apache.org on 2010/11/13 17:25:14 UTC
svn commit: r1034795 - in
/xerces/java/branches/xml-schema-1.1-dev/src/org/apache/xerces/impl/xs/traversers/override:
DOMOverrideImpl.java OverrideTransformationManager.java
Author: mrglavas
Date: Sat Nov 13 16:25:13 2010
New Revision: 1034795
URL: http://svn.apache.org/viewvc?rev=1034795&view=rev
Log:
Marking several fields which are never modified final.
Modified:
xerces/java/branches/xml-schema-1.1-dev/src/org/apache/xerces/impl/xs/traversers/override/DOMOverrideImpl.java
xerces/java/branches/xml-schema-1.1-dev/src/org/apache/xerces/impl/xs/traversers/override/OverrideTransformationManager.java
Modified: xerces/java/branches/xml-schema-1.1-dev/src/org/apache/xerces/impl/xs/traversers/override/DOMOverrideImpl.java
URL: http://svn.apache.org/viewvc/xerces/java/branches/xml-schema-1.1-dev/src/org/apache/xerces/impl/xs/traversers/override/DOMOverrideImpl.java?rev=1034795&r1=1034794&r2=1034795&view=diff
==============================================================================
--- xerces/java/branches/xml-schema-1.1-dev/src/org/apache/xerces/impl/xs/traversers/override/DOMOverrideImpl.java (original)
+++ xerces/java/branches/xml-schema-1.1-dev/src/org/apache/xerces/impl/xs/traversers/override/DOMOverrideImpl.java Sat Nov 13 16:25:13 2010
@@ -32,10 +32,10 @@ import org.w3c.dom.bootstrap.DOMImplemen
/**
* @version $Id$
*/
-public class DOMOverrideImpl extends OverrideTransformer {
+public final class DOMOverrideImpl extends OverrideTransformer {
// records all the override schema components and it's properties
- private ArrayList fOverrideComponents = new ArrayList();
+ private final ArrayList fOverrideComponents = new ArrayList();
// overridden schema document
private Document fOverridenDoc;
@@ -50,7 +50,7 @@ public class DOMOverrideImpl extends Ove
private DOMImplementation fDOMImpl;
// XSDHandler - error reporting
- private XSDHandler fSchemaHandler;
+ private final XSDHandler fSchemaHandler;
public DOMOverrideImpl(XSDHandler schemaHandler){
fSchemaHandler = schemaHandler;
@@ -310,13 +310,13 @@ public class DOMOverrideImpl extends Ove
*
* Used to store override elements and properties for later processing
*/
- private static class OverrideElement{
- int componentType;
- Element originalElement;
+ private static final class OverrideElement {
+ final int componentType;
+ final Element originalElement;
+ final String cName;
boolean overrideCloned = false;
- String cName ;
- OverrideElement(int componentType, Element elem,String cName) {
+ OverrideElement(int componentType, Element elem, String cName) {
this.componentType = componentType;
originalElement = elem;
this.cName = cName;
Modified: xerces/java/branches/xml-schema-1.1-dev/src/org/apache/xerces/impl/xs/traversers/override/OverrideTransformationManager.java
URL: http://svn.apache.org/viewvc/xerces/java/branches/xml-schema-1.1-dev/src/org/apache/xerces/impl/xs/traversers/override/OverrideTransformationManager.java?rev=1034795&r1=1034794&r2=1034795&view=diff
==============================================================================
--- xerces/java/branches/xml-schema-1.1-dev/src/org/apache/xerces/impl/xs/traversers/override/OverrideTransformationManager.java (original)
+++ xerces/java/branches/xml-schema-1.1-dev/src/org/apache/xerces/impl/xs/traversers/override/OverrideTransformationManager.java Sat Nov 13 16:25:13 2010
@@ -54,9 +54,9 @@ final public class OverrideTransformatio
// private data
private OverrideTransformer fOverrideTransformationHandler;
- private Hashtable fSystemId2ContextMap = new Hashtable();
+ private final Hashtable fSystemId2ContextMap = new Hashtable();
private int fCurrentState = STATE_INCLUDE;
- private XSDHandler fSchemaHandler;
+ private final XSDHandler fSchemaHandler;
// Constructor
public OverrideTransformationManager(XSDHandler handler, OverrideTransformer overrideHandler){
@@ -341,17 +341,15 @@ final public class OverrideTransformatio
*/
private static final class DocumentContext {
- private ArrayList fRootElementList = new ArrayList();
- private Hashtable fSchema2StateMap = new Hashtable();
+ private final ArrayList fRootElementList = new ArrayList();
+ private final Hashtable fSchema2StateMap = new Hashtable();
//indicate Transformation handler that this schema root is original
private final static Boolean IS_ORIGINAL = Boolean.TRUE;
//indicate Transformation handler that this schema root is transformed
private final static Boolean IS_TRANSFORMED = Boolean.FALSE;
- DocumentContext() {
-
- }
+ DocumentContext() {}
void addSchemasToArray(Element schemaRoot){
fRootElementList.add(schemaRoot);
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@xerces.apache.org
For additional commands, e-mail: commits-help@xerces.apache.org