[GitHub] [hudi] zhangyue19921010 commented on a change in pull request #4824: [HUDI-3430] Fix Deltastreamer to properly shut down the services upon failure

[GitBox <gi...@apache.org>]

zhangyue19921010 commented on a change in pull request #4824:
URL: https://github.com/apache/hudi/pull/4824#discussion_r807750993



##########
File path: hudi-utilities/src/main/java/org/apache/hudi/utilities/deltastreamer/HoodieDeltaStreamer.java
##########
@@ -684,6 +691,7 @@ public DeltaSync getDeltaSync() {
           }
         } finally {
           shutdownAsyncServices(error);
+          executor.shutdownNow();

Review comment:
       Hi ethan, we could use `shutdownAsyncServices(error)`to close async compaction and async clustering properly, and quit the loop and finished future directly. Is it necessary to still call `executor.shutdownNow();`here?




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org