You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@kudu.apache.org by "Grant Henke (Code Review)" <ge...@cloudera.org> on 2020/03/04 14:35:38 UTC
[kudu-CR] [build] Use Gradle to build the hms-plugin jar
Grant Henke has uploaded this change for review. ( http://gerrit.cloudera.org:8080/15360
Change subject: [build] Use Gradle to build the hms-plugin jar
......................................................................
[build] Use Gradle to build the hms-plugin jar
In an effort to unify how we build Java from cmake/make, this
patch converts the `hms-plugin.jar` compilation from using
`add_jar` to using `add_custom_command` calling a Gradle
command.
I also added `--quiet --console=plain` command line flags to
the Gradle commands to prevent weird Gradle logging within the
make build.
Change-Id: I3312b1605c4f050380264688f9d1b78038608257
---
M src/kudu/hms/CMakeLists.txt
M src/kudu/subprocess/CMakeLists.txt
2 files changed, 14 insertions(+), 10 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/60/15360/1
--
To view, visit http://gerrit.cloudera.org:8080/15360
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: newchange
Gerrit-Change-Id: I3312b1605c4f050380264688f9d1b78038608257
Gerrit-Change-Number: 15360
Gerrit-PatchSet: 1
Gerrit-Owner: Grant Henke <gr...@apache.org>
[kudu-CR] [build] Use Gradle to build the hms-plugin jar
Posted by "Attila Bukor (Code Review)" <ge...@cloudera.org>.
Attila Bukor has posted comments on this change. ( http://gerrit.cloudera.org:8080/15360 )
Change subject: [build] Use Gradle to build the hms-plugin jar
......................................................................
Patch Set 2: Code-Review+1
--
To view, visit http://gerrit.cloudera.org:8080/15360
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I3312b1605c4f050380264688f9d1b78038608257
Gerrit-Change-Number: 15360
Gerrit-PatchSet: 2
Gerrit-Owner: Grant Henke <gr...@apache.org>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Andrew Wong <aw...@cloudera.com>
Gerrit-Reviewer: Attila Bukor <ab...@apache.org>
Gerrit-Reviewer: Hao Hao <ha...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Comment-Date: Wed, 04 Mar 2020 15:20:14 +0000
Gerrit-HasComments: No
[kudu-CR] [build] Use Gradle to build the hms-plugin jar
Posted by "Grant Henke (Code Review)" <ge...@cloudera.org>.
Grant Henke has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/15360 )
Change subject: [build] Use Gradle to build the hms-plugin jar
......................................................................
[build] Use Gradle to build the hms-plugin jar
In an effort to unify how we build Java from cmake/make, this
patch converts the `hms-plugin.jar` compilation from using
`add_jar` to using `add_custom_command` calling a Gradle
command.
In order to ensure mutliple calls to Gradle don’t try and
download the `gradle-wrapper.jar` at the same time, I added an
`init-gradle` target that all Gradle commands should depend on.
I also added `--quiet --console=plain` command line flags to
the Gradle commands to prevent weird Gradle logging within the
make build.
Change-Id: I3312b1605c4f050380264688f9d1b78038608257
Reviewed-on: http://gerrit.cloudera.org:8080/15360
Tested-by: Kudu Jenkins
Reviewed-by: Adar Dembo <ad...@cloudera.com>
---
M CMakeLists.txt
M build-support/run_dist_test.py
M src/kudu/hms/CMakeLists.txt
M src/kudu/subprocess/CMakeLists.txt
4 files changed, 36 insertions(+), 18 deletions(-)
Approvals:
Kudu Jenkins: Verified
Adar Dembo: Looks good to me, approved
--
To view, visit http://gerrit.cloudera.org:8080/15360
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: merged
Gerrit-Change-Id: I3312b1605c4f050380264688f9d1b78038608257
Gerrit-Change-Number: 15360
Gerrit-PatchSet: 6
Gerrit-Owner: Grant Henke <gr...@apache.org>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Andrew Wong <aw...@cloudera.com>
Gerrit-Reviewer: Attila Bukor <ab...@apache.org>
Gerrit-Reviewer: Grant Henke <gr...@apache.org>
Gerrit-Reviewer: Hao Hao <ha...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins (120)
[kudu-CR] [build] Use Gradle to build the hms-plugin jar
Posted by "Grant Henke (Code Review)" <ge...@cloudera.org>.
Grant Henke has posted comments on this change. ( http://gerrit.cloudera.org:8080/15360 )
Change subject: [build] Use Gradle to build the hms-plugin jar
......................................................................
Patch Set 2:
We can leave this if it's preferred. I am not strongly opinionated about it.
As I see it, this is a simplification given we have 1 build tool to build Java instead of 2 (Gradle and cmake/make).
A downside to the current add_jars approach is that the dependencies used in the Gradle build and tests may be different than those in the c++ test. Using the Gradle build helps verify the published Gradle jar does in fact work.
Given these jars are only needed for tests, we should also guard these sections with the `NO_TESTS` flag. I will add that.
If speed is a concern on jenkins, I can move the Java build above the c++ build and it should look instant in the c++ build given Gradle will already be primed with all the deps and skip all tasks. If it's a concern for local builds, it should only be slower the first time. And hopefully not much.
--
To view, visit http://gerrit.cloudera.org:8080/15360
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I3312b1605c4f050380264688f9d1b78038608257
Gerrit-Change-Number: 15360
Gerrit-PatchSet: 2
Gerrit-Owner: Grant Henke <gr...@apache.org>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Andrew Wong <aw...@cloudera.com>
Gerrit-Reviewer: Attila Bukor <ab...@apache.org>
Gerrit-Reviewer: Grant Henke <gr...@apache.org>
Gerrit-Reviewer: Hao Hao <ha...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Comment-Date: Wed, 04 Mar 2020 17:40:41 +0000
Gerrit-HasComments: No
[kudu-CR] [build] Use Gradle to build the hms-plugin jar
Posted by "Andrew Wong (Code Review)" <ge...@cloudera.org>.
Andrew Wong has posted comments on this change. ( http://gerrit.cloudera.org:8080/15360 )
Change subject: [build] Use Gradle to build the hms-plugin jar
......................................................................
Patch Set 3: Code-Review+2
(3 comments)
Just some nits.
http://gerrit.cloudera.org:8080/#/c/15360/3/build-support/run_dist_test.py
File build-support/run_dist_test.py:
http://gerrit.cloudera.org:8080/#/c/15360/3/build-support/run_dist_test.py@164
PS3, Line 164: glob.glob(os.path.join(ROOT,
: "java/kudu-hive/build/libs/kudu-hive*"))[0],
: os.path.join(bin_path, "hms-plugin.jar"))
: os.symlink(
: glob.glob(os.path.join(ROOT,
: "java/kudu-subprocess/build/libs/kudu-subprocess*"))[0],
: os.path.join(bin_path, "kudu-subprocess.jar"))
nit: spacing is inconsistent between these
http://gerrit.cloudera.org:8080/#/c/15360/3/src/kudu/hms/CMakeLists.txt
File src/kudu/hms/CMakeLists.txt:
http://gerrit.cloudera.org:8080/#/c/15360/3/src/kudu/hms/CMakeLists.txt@68
PS3, Line 68: Add
nit: Adds
http://gerrit.cloudera.org:8080/#/c/15360/3/src/kudu/hms/CMakeLists.txt@77
PS3, Line 77:
nit: spacing?
--
To view, visit http://gerrit.cloudera.org:8080/15360
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I3312b1605c4f050380264688f9d1b78038608257
Gerrit-Change-Number: 15360
Gerrit-PatchSet: 3
Gerrit-Owner: Grant Henke <gr...@apache.org>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Andrew Wong <aw...@cloudera.com>
Gerrit-Reviewer: Attila Bukor <ab...@apache.org>
Gerrit-Reviewer: Grant Henke <gr...@apache.org>
Gerrit-Reviewer: Hao Hao <ha...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Comment-Date: Wed, 04 Mar 2020 22:19:15 +0000
Gerrit-HasComments: Yes
[kudu-CR] [build] Use Gradle to build the hms-plugin jar
Posted by "Grant Henke (Code Review)" <ge...@cloudera.org>.
Hello Alexey Serbin, Attila Bukor, Kudu Jenkins, Andrew Wong, Adar Dembo, Hao Hao,
I'd like you to reexamine a change. Please visit
http://gerrit.cloudera.org:8080/15360
to look at the new patch set (#4).
Change subject: [build] Use Gradle to build the hms-plugin jar
......................................................................
[build] Use Gradle to build the hms-plugin jar
In an effort to unify how we build Java from cmake/make, this
patch converts the `hms-plugin.jar` compilation from using
`add_jar` to using `add_custom_command` calling a Gradle
command.
I also added `--quiet --console=plain` command line flags to
the Gradle commands to prevent weird Gradle logging within the
make build.
Change-Id: I3312b1605c4f050380264688f9d1b78038608257
---
M build-support/run_dist_test.py
M src/kudu/hms/CMakeLists.txt
M src/kudu/subprocess/CMakeLists.txt
3 files changed, 31 insertions(+), 15 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/60/15360/4
--
To view, visit http://gerrit.cloudera.org:8080/15360
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I3312b1605c4f050380264688f9d1b78038608257
Gerrit-Change-Number: 15360
Gerrit-PatchSet: 4
Gerrit-Owner: Grant Henke <gr...@apache.org>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Andrew Wong <aw...@cloudera.com>
Gerrit-Reviewer: Attila Bukor <ab...@apache.org>
Gerrit-Reviewer: Grant Henke <gr...@apache.org>
Gerrit-Reviewer: Hao Hao <ha...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins (120)
[kudu-CR] [build] Use Gradle to build the hms-plugin jar
Posted by "Grant Henke (Code Review)" <ge...@cloudera.org>.
Hello Alexey Serbin, Attila Bukor, Kudu Jenkins, Andrew Wong, Adar Dembo, Hao Hao,
I'd like you to reexamine a change. Please visit
http://gerrit.cloudera.org:8080/15360
to look at the new patch set (#5).
Change subject: [build] Use Gradle to build the hms-plugin jar
......................................................................
[build] Use Gradle to build the hms-plugin jar
In an effort to unify how we build Java from cmake/make, this
patch converts the `hms-plugin.jar` compilation from using
`add_jar` to using `add_custom_command` calling a Gradle
command.
In order to ensure mutliple calls to Gradle don’t try and
download the `gradle-wrapper.jar` at the same time, I added an
`init-gradle` target that all Gradle commands should depend on.
I also added `--quiet --console=plain` command line flags to
the Gradle commands to prevent weird Gradle logging within the
make build.
Change-Id: I3312b1605c4f050380264688f9d1b78038608257
---
M CMakeLists.txt
M build-support/run_dist_test.py
M src/kudu/hms/CMakeLists.txt
M src/kudu/subprocess/CMakeLists.txt
4 files changed, 36 insertions(+), 18 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/60/15360/5
--
To view, visit http://gerrit.cloudera.org:8080/15360
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I3312b1605c4f050380264688f9d1b78038608257
Gerrit-Change-Number: 15360
Gerrit-PatchSet: 5
Gerrit-Owner: Grant Henke <gr...@apache.org>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Andrew Wong <aw...@cloudera.com>
Gerrit-Reviewer: Attila Bukor <ab...@apache.org>
Gerrit-Reviewer: Grant Henke <gr...@apache.org>
Gerrit-Reviewer: Hao Hao <ha...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins (120)
[kudu-CR] [build] Use Gradle to build the hms-plugin jar
Posted by "Adar Dembo (Code Review)" <ge...@cloudera.org>.
Adar Dembo has posted comments on this change. ( http://gerrit.cloudera.org:8080/15360 )
Change subject: [build] Use Gradle to build the hms-plugin jar
......................................................................
Patch Set 5: Code-Review+2
--
To view, visit http://gerrit.cloudera.org:8080/15360
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I3312b1605c4f050380264688f9d1b78038608257
Gerrit-Change-Number: 15360
Gerrit-PatchSet: 5
Gerrit-Owner: Grant Henke <gr...@apache.org>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Andrew Wong <aw...@cloudera.com>
Gerrit-Reviewer: Attila Bukor <ab...@apache.org>
Gerrit-Reviewer: Grant Henke <gr...@apache.org>
Gerrit-Reviewer: Hao Hao <ha...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Comment-Date: Thu, 05 Mar 2020 02:04:51 +0000
Gerrit-HasComments: No
[kudu-CR] [build] Use Gradle to build the hms-plugin jar
Posted by "Adar Dembo (Code Review)" <ge...@cloudera.org>.
Adar Dembo has posted comments on this change. ( http://gerrit.cloudera.org:8080/15360 )
Change subject: [build] Use Gradle to build the hms-plugin jar
......................................................................
Patch Set 2:
> We can leave this if it's preferred. I am not strongly opinionated about it.
No, I think we should either use add_jar() for all subordinate Java components, or gradle. Mixing and matching both is just more confusing.
> If speed is a concern on jenkins, I can move the Java build above the c++ build and it should look instant in the c++ build given Gradle will already be primed with all the deps and skip all tasks. If it's a concern for local builds, it should only be slower the first time. And hopefully not much.
There's just a higher fixed cost to starting gradle than there is to using add_jar(). But like I told Andrew earlier, I'm OK with trying out this approach; we can always reverse course if we don't like it.
--
To view, visit http://gerrit.cloudera.org:8080/15360
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I3312b1605c4f050380264688f9d1b78038608257
Gerrit-Change-Number: 15360
Gerrit-PatchSet: 2
Gerrit-Owner: Grant Henke <gr...@apache.org>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Andrew Wong <aw...@cloudera.com>
Gerrit-Reviewer: Attila Bukor <ab...@apache.org>
Gerrit-Reviewer: Grant Henke <gr...@apache.org>
Gerrit-Reviewer: Hao Hao <ha...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Comment-Date: Wed, 04 Mar 2020 17:52:28 +0000
Gerrit-HasComments: No
[kudu-CR] [build] Use Gradle to build the hms-plugin jar
Posted by "Alexey Serbin (Code Review)" <ge...@cloudera.org>.
Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/15360 )
Change subject: [build] Use Gradle to build the hms-plugin jar
......................................................................
Patch Set 4: Code-Review+2
> Build Failed
>
> http://jenkins.kudu.apache.org/job/kudu-gerrit/20669/ : FAILURE
The build failure in DEBUG looks relevant, but probably it's best to address it in a follow-up patch:
http://jenkins.kudu.apache.org/job/kudu-gerrit/20669/BUILD_TYPE=DEBUG
--
To view, visit http://gerrit.cloudera.org:8080/15360
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I3312b1605c4f050380264688f9d1b78038608257
Gerrit-Change-Number: 15360
Gerrit-PatchSet: 4
Gerrit-Owner: Grant Henke <gr...@apache.org>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Andrew Wong <aw...@cloudera.com>
Gerrit-Reviewer: Attila Bukor <ab...@apache.org>
Gerrit-Reviewer: Grant Henke <gr...@apache.org>
Gerrit-Reviewer: Hao Hao <ha...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Comment-Date: Thu, 05 Mar 2020 01:11:06 +0000
Gerrit-HasComments: No
[kudu-CR] [build] Use Gradle to build the hms-plugin jar
Posted by "Alexey Serbin (Code Review)" <ge...@cloudera.org>.
Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/15360 )
Change subject: [build] Use Gradle to build the hms-plugin jar
......................................................................
Patch Set 2:
(1 comment)
It seems all tests which use hms-plugin jar failed with this patch.
http://gerrit.cloudera.org:8080/#/c/15360/2/src/kudu/hms/CMakeLists.txt
File src/kudu/hms/CMakeLists.txt:
http://gerrit.cloudera.org:8080/#/c/15360/2/src/kudu/hms/CMakeLists.txt@73
PS2, Line 73: EXTRA_GRADLE_FLAGS
Why not to add --quiet flag here as well? Doing so will make it clear that all gradle flags can be overridden with EXTRA_GRADLE_FLAGS environment variable, if necessary.
--
To view, visit http://gerrit.cloudera.org:8080/15360
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I3312b1605c4f050380264688f9d1b78038608257
Gerrit-Change-Number: 15360
Gerrit-PatchSet: 2
Gerrit-Owner: Grant Henke <gr...@apache.org>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Andrew Wong <aw...@cloudera.com>
Gerrit-Reviewer: Attila Bukor <ab...@apache.org>
Gerrit-Reviewer: Hao Hao <ha...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Comment-Date: Wed, 04 Mar 2020 17:24:59 +0000
Gerrit-HasComments: Yes
[kudu-CR] [build] Use Gradle to build the hms-plugin jar
Posted by "Andrew Wong (Code Review)" <ge...@cloudera.org>.
Andrew Wong has posted comments on this change. ( http://gerrit.cloudera.org:8080/15360 )
Change subject: [build] Use Gradle to build the hms-plugin jar
......................................................................
Patch Set 4: Code-Review+2
--
To view, visit http://gerrit.cloudera.org:8080/15360
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I3312b1605c4f050380264688f9d1b78038608257
Gerrit-Change-Number: 15360
Gerrit-PatchSet: 4
Gerrit-Owner: Grant Henke <gr...@apache.org>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Andrew Wong <aw...@cloudera.com>
Gerrit-Reviewer: Attila Bukor <ab...@apache.org>
Gerrit-Reviewer: Grant Henke <gr...@apache.org>
Gerrit-Reviewer: Hao Hao <ha...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Comment-Date: Wed, 04 Mar 2020 22:39:28 +0000
Gerrit-HasComments: No
[kudu-CR] [build] Use Gradle to build the hms-plugin jar
Posted by "Grant Henke (Code Review)" <ge...@cloudera.org>.
Grant Henke has posted comments on this change. ( http://gerrit.cloudera.org:8080/15360 )
Change subject: [build] Use Gradle to build the hms-plugin jar
......................................................................
Patch Set 3:
(3 comments)
http://gerrit.cloudera.org:8080/#/c/15360/3/build-support/run_dist_test.py
File build-support/run_dist_test.py:
http://gerrit.cloudera.org:8080/#/c/15360/3/build-support/run_dist_test.py@164
PS3, Line 164: glob.glob(os.path.join(ROOT,
: "java/kudu-hive/build/libs/kudu-hive*"))[0],
: os.path.join(bin_path, "hms-plugin.jar"))
: os.symlink(
: glob.glob(os.path.join(ROOT,
: "java/kudu-subprocess/build/libs/kudu-subprocess*"))[0],
: os.path.join(bin_path, "kudu-subprocess.jar"))
> nit: spacing is inconsistent between these
Done
http://gerrit.cloudera.org:8080/#/c/15360/3/src/kudu/hms/CMakeLists.txt
File src/kudu/hms/CMakeLists.txt:
http://gerrit.cloudera.org:8080/#/c/15360/3/src/kudu/hms/CMakeLists.txt@68
PS3, Line 68: Add
> nit: Adds
Done
http://gerrit.cloudera.org:8080/#/c/15360/3/src/kudu/hms/CMakeLists.txt@77
PS3, Line 77:
> nit: spacing?
Done
--
To view, visit http://gerrit.cloudera.org:8080/15360
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I3312b1605c4f050380264688f9d1b78038608257
Gerrit-Change-Number: 15360
Gerrit-PatchSet: 3
Gerrit-Owner: Grant Henke <gr...@apache.org>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Andrew Wong <aw...@cloudera.com>
Gerrit-Reviewer: Attila Bukor <ab...@apache.org>
Gerrit-Reviewer: Grant Henke <gr...@apache.org>
Gerrit-Reviewer: Hao Hao <ha...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Comment-Date: Wed, 04 Mar 2020 22:24:27 +0000
Gerrit-HasComments: Yes
[kudu-CR] [build] Use Gradle to build the hms-plugin jar
Posted by "Grant Henke (Code Review)" <ge...@cloudera.org>.
Hello Alexey Serbin, Attila Bukor, Kudu Jenkins, Andrew Wong, Adar Dembo, Hao Hao,
I'd like you to reexamine a change. Please visit
http://gerrit.cloudera.org:8080/15360
to look at the new patch set (#2).
Change subject: [build] Use Gradle to build the hms-plugin jar
......................................................................
[build] Use Gradle to build the hms-plugin jar
In an effort to unify how we build Java from cmake/make, this
patch converts the `hms-plugin.jar` compilation from using
`add_jar` to using `add_custom_command` calling a Gradle
command.
I also added `--quiet --console=plain` command line flags to
the Gradle commands to prevent weird Gradle logging within the
make build.
Change-Id: I3312b1605c4f050380264688f9d1b78038608257
---
M src/kudu/hms/CMakeLists.txt
M src/kudu/subprocess/CMakeLists.txt
2 files changed, 23 insertions(+), 11 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/60/15360/2
--
To view, visit http://gerrit.cloudera.org:8080/15360
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I3312b1605c4f050380264688f9d1b78038608257
Gerrit-Change-Number: 15360
Gerrit-PatchSet: 2
Gerrit-Owner: Grant Henke <gr...@apache.org>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Andrew Wong <aw...@cloudera.com>
Gerrit-Reviewer: Attila Bukor <ab...@apache.org>
Gerrit-Reviewer: Hao Hao <ha...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins (120)
[kudu-CR] [build] Use Gradle to build the hms-plugin jar
Posted by "Hao Hao (Code Review)" <ge...@cloudera.org>.
Hao Hao has posted comments on this change. ( http://gerrit.cloudera.org:8080/15360 )
Change subject: [build] Use Gradle to build the hms-plugin jar
......................................................................
Patch Set 2: Code-Review+1
--
To view, visit http://gerrit.cloudera.org:8080/15360
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I3312b1605c4f050380264688f9d1b78038608257
Gerrit-Change-Number: 15360
Gerrit-PatchSet: 2
Gerrit-Owner: Grant Henke <gr...@apache.org>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Andrew Wong <aw...@cloudera.com>
Gerrit-Reviewer: Attila Bukor <ab...@apache.org>
Gerrit-Reviewer: Grant Henke <gr...@apache.org>
Gerrit-Reviewer: Hao Hao <ha...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Comment-Date: Wed, 04 Mar 2020 20:01:07 +0000
Gerrit-HasComments: No
[kudu-CR] [build] Use Gradle to build the hms-plugin jar
Posted by "Grant Henke (Code Review)" <ge...@cloudera.org>.
Hello Alexey Serbin, Attila Bukor, Kudu Jenkins, Andrew Wong, Adar Dembo, Hao Hao,
I'd like you to reexamine a change. Please visit
http://gerrit.cloudera.org:8080/15360
to look at the new patch set (#3).
Change subject: [build] Use Gradle to build the hms-plugin jar
......................................................................
[build] Use Gradle to build the hms-plugin jar
In an effort to unify how we build Java from cmake/make, this
patch converts the `hms-plugin.jar` compilation from using
`add_jar` to using `add_custom_command` calling a Gradle
command.
I also added `--quiet --console=plain` command line flags to
the Gradle commands to prevent weird Gradle logging within the
make build.
Change-Id: I3312b1605c4f050380264688f9d1b78038608257
---
M build-support/run_dist_test.py
M src/kudu/hms/CMakeLists.txt
M src/kudu/subprocess/CMakeLists.txt
3 files changed, 30 insertions(+), 14 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/60/15360/3
--
To view, visit http://gerrit.cloudera.org:8080/15360
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I3312b1605c4f050380264688f9d1b78038608257
Gerrit-Change-Number: 15360
Gerrit-PatchSet: 3
Gerrit-Owner: Grant Henke <gr...@apache.org>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Andrew Wong <aw...@cloudera.com>
Gerrit-Reviewer: Attila Bukor <ab...@apache.org>
Gerrit-Reviewer: Grant Henke <gr...@apache.org>
Gerrit-Reviewer: Hao Hao <ha...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins (120)
[kudu-CR] [build] Use Gradle to build the hms-plugin jar
Posted by "Grant Henke (Code Review)" <ge...@cloudera.org>.
Grant Henke has posted comments on this change. ( http://gerrit.cloudera.org:8080/15360 )
Change subject: [build] Use Gradle to build the hms-plugin jar
......................................................................
Patch Set 3:
(1 comment)
http://gerrit.cloudera.org:8080/#/c/15360/2/src/kudu/hms/CMakeLists.txt
File src/kudu/hms/CMakeLists.txt:
http://gerrit.cloudera.org:8080/#/c/15360/2/src/kudu/hms/CMakeLists.txt@73
PS2, Line 73: ADLE_FLAGS --quiet
> Why not to add --quiet flag here as well? Doing so will make it clear that
Done
--
To view, visit http://gerrit.cloudera.org:8080/15360
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I3312b1605c4f050380264688f9d1b78038608257
Gerrit-Change-Number: 15360
Gerrit-PatchSet: 3
Gerrit-Owner: Grant Henke <gr...@apache.org>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Andrew Wong <aw...@cloudera.com>
Gerrit-Reviewer: Attila Bukor <ab...@apache.org>
Gerrit-Reviewer: Grant Henke <gr...@apache.org>
Gerrit-Reviewer: Hao Hao <ha...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Comment-Date: Wed, 04 Mar 2020 22:04:03 +0000
Gerrit-HasComments: Yes
[kudu-CR] [build] Use Gradle to build the hms-plugin jar
Posted by "Adar Dembo (Code Review)" <ge...@cloudera.org>.
Adar Dembo has posted comments on this change. ( http://gerrit.cloudera.org:8080/15360 )
Change subject: [build] Use Gradle to build the hms-plugin jar
......................................................................
Patch Set 2: Code-Review+2
I'll go on record to say that I prefer the add_jar() approach, which more cleanly integrates with make's dependency graph and is significantly faster at build time. I understand that it's potentially more of a maintenance burden in the subprocess case, though precisely how much isn't clear to me.
--
To view, visit http://gerrit.cloudera.org:8080/15360
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I3312b1605c4f050380264688f9d1b78038608257
Gerrit-Change-Number: 15360
Gerrit-PatchSet: 2
Gerrit-Owner: Grant Henke <gr...@apache.org>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Andrew Wong <aw...@cloudera.com>
Gerrit-Reviewer: Attila Bukor <ab...@apache.org>
Gerrit-Reviewer: Hao Hao <ha...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Comment-Date: Wed, 04 Mar 2020 17:08:06 +0000
Gerrit-HasComments: No