You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@pulsar.apache.org by GitBox <gi...@apache.org> on 2021/09/28 07:41:41 UTC

[GitHub] [pulsar] fengtao1998 opened a new pull request #12220: [Docs]Update docs for Client libraries C++

fengtao1998 opened a new pull request #12220:
URL: https://github.com/apache/pulsar/pull/12220


   #### Motivation
   - Update client-libraries-c++
   - Make the document easy to read
   - Correct inappropriate punctuation
   - Correction of incorrect document
   
   
   ### Documentation
   
   Check the box below and label this PR (if you have committer privilege).
   
   Need to update docs? 
   
   - [ ] `doc-required` 
     
     (If you need help on updating docs, create a doc issue)
     
   - [ ] `no-need-doc` 
     
     (Please explain why)
     
   - [x] `doc` 
     
     (If this PR contains doc changes)
   
   
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [pulsar] fengtao1998 commented on pull request #12220: [Docs]Update docs for Client libraries C++

Posted by GitBox <gi...@apache.org>.
fengtao1998 commented on pull request #12220:
URL: https://github.com/apache/pulsar/pull/12220#issuecomment-928938242


   @Anonymitaet @Jennifer88huang PTAL


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [pulsar] Anonymitaet merged pull request #12220: [Docs]Update docs for Client libraries C++

Posted by GitBox <gi...@apache.org>.
Anonymitaet merged pull request #12220:
URL: https://github.com/apache/pulsar/pull/12220


   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [pulsar] fengtao1998 commented on pull request #12220: [Docs]Update docs for Client libraries C++

Posted by GitBox <gi...@apache.org>.
fengtao1998 commented on pull request #12220:
URL: https://github.com/apache/pulsar/pull/12220#issuecomment-928938242


   @Anonymitaet @Jennifer88huang PTAL


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [pulsar] Anonymitaet merged pull request #12220: [Docs]Update docs for Client libraries C++

Posted by GitBox <gi...@apache.org>.
Anonymitaet merged pull request #12220:
URL: https://github.com/apache/pulsar/pull/12220


   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [pulsar] Jennifer88huang commented on a change in pull request #12220: [Docs]Update docs for Client libraries C++

Posted by GitBox <gi...@apache.org>.
Jennifer88huang commented on a change in pull request #12220:
URL: https://github.com/apache/pulsar/pull/12220#discussion_r717399717



##########
File path: site2/docs/client-libraries-cpp.md
##########
@@ -10,7 +10,7 @@ All the methods in producer, consumer, and reader of a C++ client are thread-saf
 
 ## Supported platforms
 
-Pulsar C++ client is supported on **Linux** and **MacOS** platforms.
+Pulsar C++ client is supported on **Linux** ,**MacOS** and **Windows(64-bit)** platforms.

Review comment:
       @BewareMyPower Thanks for your comment.
   @fengtao1998 you can update the Pulsar 2.8.1 doc with the above comment as well. Thank you.




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [pulsar] BewareMyPower commented on a change in pull request #12220: [Docs]Update docs for Client libraries C++

Posted by GitBox <gi...@apache.org>.
BewareMyPower commented on a change in pull request #12220:
URL: https://github.com/apache/pulsar/pull/12220#discussion_r717355878



##########
File path: site2/docs/client-libraries-cpp.md
##########
@@ -10,7 +10,7 @@ All the methods in producer, consumer, and reader of a C++ client are thread-saf
 
 ## Supported platforms
 
-Pulsar C++ client is supported on **Linux** and **MacOS** platforms.
+Pulsar C++ client is supported on **Linux** ,**MacOS** and **Windows(64-bit)** platforms.

Review comment:
       Windows 32 bit is supported after https://github.com/apache/pulsar/pull/11082 (from 2.8.1).




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [pulsar] BewareMyPower commented on a change in pull request #12220: [Docs]Update docs for Client libraries C++

Posted by GitBox <gi...@apache.org>.
BewareMyPower commented on a change in pull request #12220:
URL: https://github.com/apache/pulsar/pull/12220#discussion_r717355878



##########
File path: site2/docs/client-libraries-cpp.md
##########
@@ -10,7 +10,7 @@ All the methods in producer, consumer, and reader of a C++ client are thread-saf
 
 ## Supported platforms
 
-Pulsar C++ client is supported on **Linux** and **MacOS** platforms.
+Pulsar C++ client is supported on **Linux** ,**MacOS** and **Windows(64-bit)** platforms.

Review comment:
       Windows 32 bit is supported after https://github.com/apache/pulsar/pull/11082 (from 2.8.1).




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [pulsar] Jennifer88huang commented on a change in pull request #12220: [Docs]Update docs for Client libraries C++

Posted by GitBox <gi...@apache.org>.
Jennifer88huang commented on a change in pull request #12220:
URL: https://github.com/apache/pulsar/pull/12220#discussion_r717399717



##########
File path: site2/docs/client-libraries-cpp.md
##########
@@ -10,7 +10,7 @@ All the methods in producer, consumer, and reader of a C++ client are thread-saf
 
 ## Supported platforms
 
-Pulsar C++ client is supported on **Linux** and **MacOS** platforms.
+Pulsar C++ client is supported on **Linux** ,**MacOS** and **Windows(64-bit)** platforms.

Review comment:
       @BewareMyPower Thanks for your comment.
   @fengtao1998 you can update the Pulsar 2.8.1 doc with the above comment as well. Thank you.




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org