[GitHub] [spark] HyukjinKwon commented on a change in pull request #35626: [SPARK-38240][SQL][FOLLOW-UP] Make RuntimeReplaceableAggregate as an add-on of RuntimeReplaceable

[GitBox <gi...@apache.org>]

HyukjinKwon commented on a change in pull request #35626:
URL: https://github.com/apache/spark/pull/35626#discussion_r812688206



##########
File path: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/aggregate/CountIf.scala
##########
@@ -34,8 +34,11 @@ import org.apache.spark.sql.types.{AbstractDataType, BooleanType}
   """,
   group = "agg_funcs",
   since = "3.0.0")
-case class CountIf(child: Expression) extends RuntimeReplaceableAggregate
-  with ImplicitCastInputTypes with UnaryLike[Expression] {
+case class CountIf(child: Expression)
+    extends RuntimeReplaceable
+    with ReplaceableAggregateFunction

Review comment:
       I checked runtime replaceable aggregate functions. Seems like none requires `InheritAnalysisRules` for now.




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org