You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@streampark.apache.org by be...@apache.org on 2022/10/11 10:23:26 UTC

[incubator-streampark] branch dev updated: [Infra] Modified pull request template and add pull-request-robot workflow (#1806)

This is an automated email from the ASF dual-hosted git repository.

benjobs pushed a commit to branch dev
in repository https://gitbox.apache.org/repos/asf/incubator-streampark.git


The following commit(s) were added to refs/heads/dev by this push:
     new b1b00357c [Infra] Modified pull request template and add pull-request-robot workflow (#1806)
b1b00357c is described below

commit b1b00357cfd1abe3abc9a2a3d541f2382d475572
Author: Shaokang Lv <lv...@hotmail.com>
AuthorDate: Tue Oct 11 18:23:17 2022 +0800

    [Infra] Modified pull request template and add pull-request-robot workflow (#1806)
    
    * add labeler.yml
    
    * add CODEOWNERS
    
    * modified PULL_REQUEST_TEMPLATE.md
---
 .github/PULL_REQUEST_TEMPLATE.md         | 45 ++++++++++++++++------
 .github/labeler.yml                      | 66 ++++++++++++++++++++++++++++++++
 .github/workflows/pull-request-robot.yml | 40 +++++++++++++++++++
 3 files changed, 139 insertions(+), 12 deletions(-)

diff --git a/.github/PULL_REQUEST_TEMPLATE.md b/.github/PULL_REQUEST_TEMPLATE.md
index 267d75368..33d0fc864 100644
--- a/.github/PULL_REQUEST_TEMPLATE.md
+++ b/.github/PULL_REQUEST_TEMPLATE.md
@@ -1,31 +1,52 @@
 <!--
-
 Thank you for contributing to StreamPark! Please make sure that your code changes
 are covered with tests. And in case of new features or big changes
 remember to adjust the documentation.
 
+## Contribution Checklist
+
+  - If this is your first time, please read our contributor guidelines: [Submit Code](https://streampark.apache.org/community/submit_guide/submit_code).
+
+  - Make sure that the pull request corresponds to a [GITHUB issue](https://github.com/apache/streampark/issues).
+
+  - Name the pull request in the form "[Feature] Title of the pull request", where *Feature* can be replaced by `Hotfix`, `Bug`, etc.
+
+  - Fill out the template below to describe the changes contributed by the pull request. That will give reviewers the context they need to do the review.
+
+  - If the PR is unfinished, add `[WIP]` in your PR title, e.g., `[WIP][Feature] Title of the pull request`.
+
 -->
 
-## What problem does this PR solve?
+## What changes were proposed in this pull request
 
 Issue Number: close #xxx <!-- REMOVE this line if no issue to close -->
 
-Problem Summary:
+<!--(For example: This pull request proposed to add checkstyle plugin).-->
 
-## What is changed and how it works?
+## Brief change log
 
-Proposal: url address <!-- REMOVE this line if not applicable -->
+<!--*(for example:)*
+- *Add maven-checkstyle-plugin to root pom.xml*
+-->
 
-Feel free to ping committers for the review!
+## Verifying this change
 
-## Contribution Checklist
+<!--*(Please pick either of the following options)*-->
 
-  - Make sure that the pull request corresponds to a [GITHUB issue](https://github.com/apache/streampark/issues).
+This change is a trivial rework / code cleanup without any test coverage.
+
+*(or)*
+
+This change is already covered by existing tests, such as *(please describe tests)*.
 
-  - Name the pull request in the form "[Feature] [component] Title of the pull request", where *Feature* can be replaced by `Hotfix`, `Bug`, etc.
+*(or)*
 
-  - Minor fixes should be named following this pattern: `[hotfix] [docs] Fix typo in README.md doc`.
+This change added tests and can be verified as follows:
 
-## Purpose of this pull request
+<!--*(example:)*
+- *Added integration tests for end-to-end.*
+- *Added *Test to verify the change.*
+- *Manually verified the change by testing locally.* -->
 
-<!-- Describe the purpose of this pull request. For example: This pull request adds checkstyle plugin.-->
+## Does this pull request potentially affect one of the following parts
+ - Dependencies (does it add or upgrade a dependency): (yes / no)
diff --git a/.github/labeler.yml b/.github/labeler.yml
new file mode 100644
index 000000000..f38f1168f
--- /dev/null
+++ b/.github/labeler.yml
@@ -0,0 +1,66 @@
+# Licensed to the Apache Software Foundation (ASF) under one
+# or more contributor license agreements.  See the NOTICE file
+# distributed with this work for additional information
+# regarding copyright ownership.  The ASF licenses this file
+# to you under the Apache License, Version 2.0 (the
+# "License"); you may not use this file except in compliance
+# with the License.  You may obtain a copy of the License at
+#
+#     http://www.apache.org/licenses/LICENSE-2.0
+#
+# Unless required by applicable law or agreed to in writing, software
+# distributed under the License is distributed on an "AS IS" BASIS,
+# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+# See the License for the specific language governing permissions and
+# limitations under the License.
+#
+
+INFRA:
+  - ".github/**/*"
+  - ".asf.yaml"
+  - ".editorconfig"
+  - ".gitignore"
+  - ".licenserc.yaml"
+
+BUILD:
+  - ".husky/**/*"
+  - ".mvn/**/*"
+  - "script/update_version.py"
+  - "tools/checkstyle/*"
+  - "build.sh"
+  - "mvnw"
+  - "mvnw.cmd"
+  - "**/*pom.xml"
+  - "**/assembly/**/*"
+
+DOCKER:
+  - "deploy/**/*"
+
+DOCS:
+  - "**/README.md"
+  - "**/README_CN.md"
+
+WEB UI:
+  - "streampark-console/streampark-console-webapp/**/*"
+
+BACKEND:
+  - "streampark-console/streampark-console-server/**/*"
+  - "streampark-common/**/*"
+  - "streampark-plugin/**/*"
+
+FLINK:
+  - "streampark-flink/**/*"
+
+SPARK:
+  - "streampark-spark/**/*"
+
+KUBERNETES:
+  - "streampark-flink/streampark-flink-kubernetes/**/*"
+  - "streampark-flink-submit/**/Kubernetes*.scala"
+
+YARN:
+  - "streampark-common/**/Yarn*.scala"
+  - "streampark-flink-submit/**/Yarn*.scala"
+
+WINDOWS:
+  - "**/*.cmd"
diff --git a/.github/workflows/pull-request-robot.yml b/.github/workflows/pull-request-robot.yml
new file mode 100644
index 000000000..8db825a01
--- /dev/null
+++ b/.github/workflows/pull-request-robot.yml
@@ -0,0 +1,40 @@
+#
+# Licensed to the Apache Software Foundation (ASF) under one or more
+# contributor license agreements.  See the NOTICE file distributed with
+# this work for additional information regarding copyright ownership.
+# The ASF licenses this file to You under the Apache License, Version 2.0
+# (the "License"); you may not use this file except in compliance with
+# the License.  You may obtain a copy of the License at
+#
+#    https://www.apache.org/licenses/LICENSE-2.0
+#
+# Unless required by applicable law or agreed to in writing, software
+# distributed under the License is distributed on an "AS IS" BASIS,
+# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+# See the License for the specific language governing permissions and
+# limitations under the License.
+#
+
+name: "pull-request-robot"
+on:
+  - pull_request_target
+
+jobs:
+  labelRobot:
+    permissions:
+      contents: read
+      pull-requests: write
+    runs-on: ubuntu-latest
+    steps:
+      - name: "Checkout ${{ github.ref }}"
+        uses: actions/checkout@v3
+        with:
+          persist-credentials: false
+          submodules: true
+
+      - name: "Label in pull request"
+        uses: actions/labeler@v4
+        with:
+          repo-token: "${{ secrets.GITHUB_TOKEN }}"
+          configuration-path: .github/labeler.yml
+          sync-labels: true