[GitHub] [geode] sboorlagadda opened pull request #2563: GEODE-5787: support dunit VM bounce on Windows

["sboorlagadda (GitHub)" <gi...@apache.org>]

Signed-off-by: Kirk Lund <kl...@apache.org>

Thank you for submitting a contribution to Apache Geode.

In order to streamline the review of the contribution we ask you
to ensure the following steps have been taken:

### For all changes:
- [ ] Is there a JIRA ticket associated with this PR? Is it referenced in the commit message?

- [ ] Has your PR been rebased against the latest commit within the target branch (typically `develop`)?

- [ ] Is your initial contribution a single, squashed commit?

- [ ] Does `gradlew build` run cleanly?

- [ ] Have you written or updated unit tests to verify your changes?

- [ ] If adding new dependencies to the code, are these dependencies licensed in a way that is compatible for inclusion under [ASF 2.0](http://www.apache.org/legal/resolved.html#category-a)?

### Note:
Please ensure that once the PR is submitted, you check travis-ci for build issues and
submit an update to your PR as soon as possible. If you need help, please send an
email to dev@geode.apache.org.


[ Full content available at: https://github.com/apache/geode/pull/2563 ]
This message was relayed via gitbox.apache.org for notifications@geode.apache.org

[GitHub] [geode] sboorlagadda commented on pull request #2563: GEODE-5787: support dunit VM bounce on Windows

["sboorlagadda (GitHub)" <gi...@apache.org>]

Fixed.

[ Full content available at: https://github.com/apache/geode/pull/2563 ]
This message was relayed via gitbox.apache.org for notifications@geode.apache.org

[GitHub] [geode] pivotal-jbarrett commented on issue #2563: GEODE-5787: support dunit VM bounce on Windows

["pivotal-jbarrett (GitHub)" <gi...@apache.org>]

@sboorlagadda are you waiting for something before merging these approved changes, besides resolving conflicts?


[ Full content available at: https://github.com/apache/geode/pull/2563 ]
This message was relayed via gitbox.apache.org for notifications@geode.apache.org

[GitHub] [geode] sboorlagadda closed pull request #2563: GEODE-5787: support dunit VM bounce on Windows

["sboorlagadda (GitHub)" <gi...@apache.org>]

[ pull request closed by sboorlagadda ]

[ Full content available at: https://github.com/apache/geode/pull/2563 ]
This message was relayed via gitbox.apache.org for notifications@geode.apache.org

[GitHub] [geode] kirklund commented on pull request #2563: GEODE-5787: support dunit VM bounce on Windows

["kirklund (GitHub)" <gi...@apache.org>]

I recommend changing this to:
```
private static final Logger = LogService.getLogger();

logger.error("VM bounce thread interrupted before exiting.", e);
```

[ Full content available at: https://github.com/apache/geode/pull/2563 ]
This message was relayed via gitbox.apache.org for notifications@geode.apache.org

[GitHub] [geode] sboorlagadda commented on issue #2563: GEODE-5787: support dunit VM bounce on Windows

["sboorlagadda (GitHub)" <gi...@apache.org>]

@pivotal-jbarrett Yes, I need to just resolve conflicts and this will be ready to merge.

[ Full content available at: https://github.com/apache/geode/pull/2563 ]
This message was relayed via gitbox.apache.org for notifications@geode.apache.org

[GitHub] [geode] kirklund commented on pull request #2563: GEODE-5787: support dunit VM bounce on Windows

["kirklund (GitHub)" <gi...@apache.org>]

Was there an exception thrown in the controller? Since 100 still might not be enough on occasion, maybe we should catch the exception in the controller.

[ Full content available at: https://github.com/apache/geode/pull/2563 ]
This message was relayed via gitbox.apache.org for notifications@geode.apache.org

[GitHub] [geode] sboorlagadda commented on issue #2563: GEODE-5787: support dunit VM bounce on Windows

["sboorlagadda (GitHub)" <gi...@apache.org>]

@jdeppe-pivotal @kirklund I would like to request another review on this PR as it is now passing tests.

[ Full content available at: https://github.com/apache/geode/pull/2563 ]
This message was relayed via gitbox.apache.org for notifications@geode.apache.org

[GitHub] [geode] sboorlagadda commented on pull request #2563: GEODE-5787: support dunit VM bounce on Windows

["sboorlagadda (GitHub)" <gi...@apache.org>]

The sleep avoids running the new thread immediately so the return can succeed.

[ Full content available at: https://github.com/apache/geode/pull/2563 ]
This message was relayed via gitbox.apache.org for notifications@geode.apache.org