You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@iotdb.apache.org by GitBox <gi...@apache.org> on 2022/12/28 09:20:20 UTC
[GitHub] [iotdb] CRZbulabula opened a new pull request, #8643: [IOTDB-5282] Add SQL: show cluster parameter
CRZbulabula opened a new pull request, #8643:
URL: https://github.com/apache/iotdb/pull/8643
**Add the following SQL:**
```
SHOW CLUSTER PARAMETERS
```
Which supports to display the basic cluster parameters for the user as shown in the below pic:
<img width="1242" alt="image" src="https://user-images.githubusercontent.com/33111881/209788102-812b491c-d952-48da-b628-845727493099.png">
**Code updates:**
1. Add SQL `SHOW CLUSTER PARAMETERS`
2. Simplify the SQL parser for `SHOW CLUSTER`, `SHOW CLUSTER DETAILS` and `SHOW CLUSTER PARAMETERS`
3. Cluster parameters are divided into `TBasicClusterParameters` and `TAdvancedClusterParameters`, for which you'll see in the `confignode.thrift` file. Every parameters in both `TBasicClusterParameters` and `TAdvancedClusterParameters` should be consist in each Cluster Node. **The new SQL `SHOW CLUSTER PARAMETERS` only display those parameters in `TBasicClusterParameters`** since this new SQL is mostly for freshman of IoTDB. Therefore the result of this SQL won't be too tedious to read. Also, if a user attempts to modify the `TAdvancedClusterParameters`, it means the user is familiar with our IoTDB cluster. Thus, he/she can read the `.properties` files instead of using `SHOW CLUSTER PARAMETERS`.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@iotdb.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [iotdb] Beyyes merged pull request #8643: [IOTDB-5282] Add SQL: show cluster parameter
Posted by GitBox <gi...@apache.org>.
Beyyes merged PR #8643:
URL: https://github.com/apache/iotdb/pull/8643
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@iotdb.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [iotdb] Beyyes commented on a diff in pull request #8643: [IOTDB-5282] Add SQL: show cluster parameter
Posted by GitBox <gi...@apache.org>.
Beyyes commented on code in PR #8643:
URL: https://github.com/apache/iotdb/pull/8643#discussion_r1058402084
##########
integration-test/src/test/java/org/apache/iotdb/confignode/it/cluster/IoTDBClusterNodeErrorStartUpIT.java:
##########
@@ -240,7 +247,8 @@ public void testIllegalNodeRestart()
// Shutdown and check
EnvFactory.getEnv().shutdownConfigNode(1);
EnvFactory.getEnv().shutdownDataNode(0);
- while (true) {
+ int retryTimes;
+ for (retryTimes = 0; retryTimes < maxRetryTimes; retryTimes++) {
Review Comment:
These codes has been merged into master. Maybe this branch should merge with master.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@iotdb.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [iotdb] CRZbulabula commented on a diff in pull request #8643: [IOTDB-5282] Add SQL: show cluster parameter
Posted by GitBox <gi...@apache.org>.
CRZbulabula commented on code in PR #8643:
URL: https://github.com/apache/iotdb/pull/8643#discussion_r1058693908
##########
integration-test/src/test/java/org/apache/iotdb/confignode/it/cluster/IoTDBClusterNodeErrorStartUpIT.java:
##########
@@ -240,7 +247,8 @@ public void testIllegalNodeRestart()
// Shutdown and check
EnvFactory.getEnv().shutdownConfigNode(1);
EnvFactory.getEnv().shutdownDataNode(0);
- while (true) {
+ int retryTimes;
+ for (retryTimes = 0; retryTimes < maxRetryTimes; retryTimes++) {
Review Comment:
These codes are cherry-picked from the master
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@iotdb.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org