You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@trafficcontrol.apache.org by GitBox <gi...@apache.org> on 2019/11/08 17:24:45 UTC

[GitHub] [trafficcontrol] ocket8888 edited a comment on issue #4093: Admin can map Federal Resolver with Invalid mapping parameter or without mapping parameter

ocket8888 edited a comment on issue #4093: Admin can map Federal Resolver with Invalid mapping parameter or without mapping parameter
URL: https://github.com/apache/trafficcontrol/issues/4093#issuecomment-551916760
 
 
   > _" Admin can map Federal Resolver with Invalid mapping parameter or without mapping parameter"_
   No, they can't. The success message here is erroneous, no actual mapping is created. Also, as has been explained in a previous issue (I forget the number), Traffic Ops will ignore unrecognized parameters.
   
   So what this boils down to is "mappings" isn't required - and I feel you, it really ought to be IMO. But the current behavior is consistent with Perl:
   ```http
   POST /api/1.3/federations HTTP/1.1
   User-Agent: python-requests/2.22.0
   Accept-Encoding: gzip, deflate
   Accept: */*
   Connection: keep-alive
   Cookie: mojolicious=...
   Content-Length: 28
   
   {"deliveryService": "demo1"}
   ```
   results in
   ```http
   HTTP/1.1 200 OK
   Connection: keep-alive
   Access-Control-Allow-Credentials: true
   Access-Control-Allow-Headers: Origin, X-Requested-With, Content-Type, Accept
   Set-Cookie: mojolicious=eyJhdXRoX2RhdGEiOiJhZG1pbiIsImV4cGlyZXMiOjE1NzMyNDgwNDR9--98fb1a79cd4902c3b9a0a20ee54c6212a95c9510; expires=Fri, 08 Nov 2019 21:20:44 GMT; path=/; HttpOnly
   Whole-Content-SHA512: dXg86uD2Un1AeBCeeBLSo2rsYgl6NOHHQEc5oMlpw1THOh2HwGdjwB3rPd/qoYIhOxcnnHoEstrEiHmucFev4A==
   Cache-Control: no-cache, no-store, max-age=0, must-revalidate
   Date: Fri, 08 Nov 2019 17:20:44 GMT
   Access-Control-Allow-Origin: *
   Content-Encoding: gzip
   Vary: Accept-Encoding
   Access-Control-Allow-Methods: POST,GET,OPTIONS,PUT,DELETE
   Content-Length: 81
   Content-Type: application/json
   Server: Mojolicious (Perl)
   
   {
   	"response": "admin successfully created federation resolvers."
   }
   ```

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services