You are viewing a plain text version of this content. The canonical link for it is here.

Posted to issues@orc.apache.org by "Dongjoon Hyun (Jira)" <ji...@apache.org> on 2020/11/05 21:14:00 UTC

[jira] [Resolved] (ORC-683) PPD: Make Floating point NaN check more strict

     [ https://issues.apache.org/jira/browse/ORC-683?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Dongjoon Hyun resolved ORC-683.
-------------------------------
    Fix Version/s: 1.7.0
                   1.6.6
       Resolution: Fixed

This is resolved via https://github.com/apache/orc/pull/562

> PPD: Make Floating point NaN check more strict
> ----------------------------------------------
>
>                 Key: ORC-683
>                 URL: https://issues.apache.org/jira/browse/ORC-683
>             Project: ORC
>          Issue Type: Improvement
>    Affects Versions: 1.4.4, 1.4.5, 1.6.3, 1.6.4, 1.6.5, 1.7.0
>            Reporter: Panagiotis Garefalakis
>            Assignee: Panagiotis Garefalakis
>            Priority: Minor
>             Fix For: 1.6.6, 1.7.0
>
>
> ORC-629 added an extra check (part of  RecordReaderImp) disabling PPD when DoubleColumnStats min, max or sum is a non-Finite number.
> However, the check is unnecessarily broad – the way stats are updated, using just sum for the check would suffice.
>  [https://github.com/apache/orc/blob/master/java/core/src/java/org/apache/orc/impl/ColumnStatisticsImpl.java#L568]



--
This message was sent by Atlassian Jira
(v8.3.4#803005)