You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@pig.apache.org by jc...@apache.org on 2013/01/24 00:16:14 UTC
svn commit: r1437796 - in /pig/trunk: CHANGES.txt
src/org/apache/pig/backend/hadoop/executionengine/physicalLayer/expressionOperators/POUserFunc.java
Author: jcoveney
Date: Wed Jan 23 23:16:14 2013
New Revision: 1437796
URL: http://svn.apache.org/viewvc?rev=1437796&view=rev
Log:
PIG-3073: POUserFunc creating log spam for large scripts (jcoveney)
Modified:
pig/trunk/CHANGES.txt
pig/trunk/src/org/apache/pig/backend/hadoop/executionengine/physicalLayer/expressionOperators/POUserFunc.java
Modified: pig/trunk/CHANGES.txt
URL: http://svn.apache.org/viewvc/pig/trunk/CHANGES.txt?rev=1437796&r1=1437795&r2=1437796&view=diff
==============================================================================
--- pig/trunk/CHANGES.txt (original)
+++ pig/trunk/CHANGES.txt Wed Jan 23 23:16:14 2013
@@ -24,6 +24,8 @@ INCOMPATIBLE CHANGES
IMPROVEMENTS
+PIG-3073: POUserFunc creating log spam for large scripts (jcoveney)
+
PIG-3082: outputSchema of a UDF allows two usages when describing a Tuple schema (jcoveney)
PIG-3124: Push FLATTENs After FILTERs If Possible (nwhite via daijy)
Modified: pig/trunk/src/org/apache/pig/backend/hadoop/executionengine/physicalLayer/expressionOperators/POUserFunc.java
URL: http://svn.apache.org/viewvc/pig/trunk/src/org/apache/pig/backend/hadoop/executionengine/physicalLayer/expressionOperators/POUserFunc.java?rev=1437796&r1=1437795&r2=1437796&view=diff
==============================================================================
--- pig/trunk/src/org/apache/pig/backend/hadoop/executionengine/physicalLayer/expressionOperators/POUserFunc.java (original)
+++ pig/trunk/src/org/apache/pig/backend/hadoop/executionengine/physicalLayer/expressionOperators/POUserFunc.java Wed Jan 23 23:16:14 2013
@@ -27,8 +27,6 @@ import java.util.List;
import java.util.Map;
import java.util.Properties;
-import org.joda.time.DateTime;
-
import org.apache.commons.logging.Log;
import org.apache.commons.logging.LogFactory;
import org.apache.hadoop.conf.Configuration;
@@ -60,6 +58,7 @@ import org.apache.pig.impl.plan.Operator
import org.apache.pig.impl.plan.VisitorException;
import org.apache.pig.impl.util.UDFContext;
import org.apache.pig.tools.pigstats.PigStatusReporter;
+import org.joda.time.DateTime;
public class POUserFunc extends ExpressionOperator {
private static final Log LOG = LogFactory.getLog(POUserFunc.class);
@@ -166,8 +165,6 @@ public class POUserFunc extends Expressi
if (jobConf != null) {
doTiming = "true".equalsIgnoreCase(jobConf.get(TIME_UDFS_PROP, "false"));
counterGroup = funcSpec.toString();
- } else {
- LOG.warn("jobConf not available. Not tracking UDF timing regardless of user preference.");
}
// We initialize here instead of instantiateFunc because this is called
// when actual processing has begun, whereas a function can be instantiated
@@ -318,7 +315,7 @@ public class POUserFunc extends Expressi
// so that udf gets called both when isAccumStarted
// is first true and then set to false, even
//when the input relation is empty.
- // so the STATUS_EOP has to be sent from POUserFunc,
+ // so the STATUS_EOP has to be sent from POUserFunc,
// after the results have been sent.
result.result = null;
result.returnStatus = POStatus.STATUS_EOP;
@@ -421,7 +418,7 @@ public class POUserFunc extends Expressi
return getNext();
}
-
+
@Override
public Result getNext(Map m) throws ExecException {
@@ -590,16 +587,16 @@ public class POUserFunc extends Expressi
public void setResultType(byte resultType) {
this.resultType = resultType;
}
-
+
@Override
public Tuple illustratorMarkup(Object in, Object out, int eqClassIndex) {
return (Tuple) out;
}
-
+
public EvalFunc getFunc() {
return func;
}
-
+
public void setSignature(String signature) {
this.signature = signature;
if (this.func!=null) {