[GitHub] flink pull request #4418: [FLINK-7293] [cep] Support custom order by in Patt...

[dawidwys <gi...@git.apache.org>]

Github user dawidwys commented on a diff in the pull request:

    https://github.com/apache/flink/pull/4418#discussion_r130564756
  
    --- Diff: flink-libraries/flink-cep-scala/src/main/scala/org/apache/flink/cep/scala/CEP.scala ---
    @@ -36,8 +38,26 @@ object CEP {
         * @tparam T Type of the input events
         * @return Resulting pattern stream
         */
    -  def pattern[T](input: DataStream[T], pattern: Pattern[T, _]): PatternStream[T] = {
    +  def pattern[T](input: DataStream[T], pattern: Pattern[T, _ <: T]): PatternStream[T] = {
         wrapPatternStream(JCEP.pattern(input.javaStream, pattern.wrappedPattern))
       }
    +
    +  /**
    +    * Transforms a [[DataStream]] into a [[PatternStream]] in the Scala API.
    +    * See [[org.apache.flink.cep.CEP}]]for a more detailed description how the underlying
    +    * Java API works.
    +    *
    +    * @param input      DataStream containing the input events
    +    * @param pattern    Pattern specification which shall be detected
    +    * @param comparator Comparator to sort events
    --- End diff --
    
    could you describe in the doc when the operator is applied.
    
    E.g the comparator is used for sorting events with the same timestamp in case of EventTime or that arrived at the same moment.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---